chore(NA): add uiSharedDeps into canvas shareable_runtime build#62807
Closed
mistic wants to merge 2 commits intoelastic:masterfrom
Closed
chore(NA): add uiSharedDeps into canvas shareable_runtime build#62807mistic wants to merge 2 commits intoelastic:masterfrom
mistic wants to merge 2 commits intoelastic:masterfrom
Conversation
mistic
added
chore
v8.0.0
release_note:skip
Contributor
|
Pinging @elastic/kibana-operations (Team:Operations) |
Contributor
|
@mistic This isn't going to work. The canvas shareable_runtime build is intended to contain everything needed to embed a workpad on an external site. Moving all the dependencies to shared here causes that to break because the embed location likely doesn't have those dependencies. |
Contributor
Author
|
@crob611 It might defeat the purpose have to running the shared-ui-deps too. I'll close the PR then. Thanks for the input |
Contributor
💚 Build SucceededTo update your PR or re-run it, just comment with: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
That adds UiSharedDeps into canvas shareable_runtime build which reduces
kbn_canvasfrom9.7MBinto4.34MB.