[7.x] Add service map icon for rum-js agent type (#62721)#62796
Merged
smith merged 1 commit intoelastic:7.xfrom Apr 7, 2020
Merged
[7.x] Add service map icon for rum-js agent type (#62721)#62796smith merged 1 commit intoelastic:7.xfrom
smith merged 1 commit intoelastic:7.xfrom
Conversation
* Add service map icon for rum-js agent type We previously were only checking for "js-base" as the RUM `agent.name` but it can report either "js-base" or "rum-js", so make that work. I saw an "opbeans-react" service on a map generated by apm-integration-testing that Gil had running last week. Not sure if that's a newer or older version because I don't see it on apm.elstc.co. Also clean up the icons storybook a little. Fixes elastic#62336. * use isRumAgentName Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Contributor
💚 Build SucceededTo update your PR or re-run it, just comment with: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backports the following commits to 7.x: