Skip to content

[REVERT THE REVERT] [Monitoring] Cluster state watch to Kibana alerting #62793

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 7, 2020
Merged

[REVERT THE REVERT] [Monitoring] Cluster state watch to Kibana alerting #62793

merged 3 commits into from
Apr 7, 2020

Conversation

@chrisronline
Copy link
Contributor

@chrisronline chrisronline commented Apr 7, 2020

Fixes the localization issues that came up after merging #61685 into master.

@chrisronline chrisronline added review Team:Monitoring Stack Monitoring team v8.0.0 release_note:skip Skip the PR/issue when compiling release notes Feature:Stack Monitoring v7.8.0 labels Apr 7, 2020
@chrisronline chrisronline requested a review from a team April 7, 2020 14:19
@chrisronline chrisronline self-assigned this Apr 7, 2020
@elasticmachine
Copy link
Contributor

elasticmachine commented Apr 7, 2020

Pinging @elastic/stack-monitoring (Team:Monitoring)

igoristic
igoristic approved these changes Apr 7, 2020
View reviewed changes
Copy link
Contributor

@igoristic igoristic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go once CI is 💚

@kibanamachine
Copy link
Contributor

kibanamachine commented Apr 7, 2020

💚 Build Succeeded

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@chrisronline chrisronline merged commit 8ffc08f into elastic:master Apr 7, 2020
@chrisronline chrisronline deleted the new_alert2 branch April 7, 2020 17:44
chrisronline added a commit to chrisronline/kibana that referenced this pull request Apr 7, 2020
@chrisronline
[REVERT THE REVERT] [Monitoring] Cluster state watch to Kibana alerti…
c00e33f 
…ng (elastic#62793)

* Revert "Revert "[Monitoring] Cluster state watch to Kibana alerting (elastic#61685)""

This reverts commit f1bd3bd.

* Fix i18n error

* Fix test
@chrisronline chrisronline mentioned this pull request Apr 7, 2020
Merged
chrisronline added a commit that referenced this pull request Apr 7, 2020
@chrisronline
[REVERT THE REVERT] [Monitoring] Cluster state watch to Kibana alerti…
f6a4c71 
…ng (#62793) (#62838)

* Revert "Revert "[Monitoring] Cluster state watch to Kibana alerting (#61685)""

This reverts commit f1bd3bd.

* Fix i18n error

* Fix test
@chrisronline
Copy link
Contributor Author

chrisronline commented Apr 7, 2020

Backport:

7.x: f6a4c71

@chrisronline chrisronline mentioned this pull request Jun 10, 2020
Merged
10 tasks
@kibanamachine kibanamachine mentioned this pull request Feb 16, 2022
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@igoristic igoristic igoristic approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@chrisronline chrisronline

Labels

Feature:Stack Monitoring release_note:skip Skip the PR/issue when compiling release notes review Team:Monitoring Stack Monitoring team v7.8.0 v8.0.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@chrisronline @elasticmachine @kibanamachine @igoristic