[ML] Adding configurable file size to file data visualizer#62752
Merged
jgowdyelastic merged 2 commits intoelastic:masterfrom Apr 8, 2020
Merged
Conversation
jgowdyelastic
requested review from
alvarezmelissa87,
darnautov,
peteharverson and
walterra
jgowdyelastic
added
:ml
Feature:File and Index Data Viz
Contributor
|
Pinging @elastic/ml-ui (:ml) |
Member
Author
|
cc @droberts195 |
Member
Author
|
related to #61735 |
Contributor
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
peteharverson
approved these changes
Apr 7, 2020
Contributor
peteharverson
left a comment
peteharverson
left a comment
There was a problem hiding this comment.
Tested and LGTM.
I found a couple of pages in the docs which need edits:
jgowdyelastic
deleted the
add-configurable-file-size-to-file-data-visualizer
branch
jgowdyelastic
added a commit
to jgowdyelastic/kibana
that referenced
this pull request
Apr 8, 2020
…2752) * [ML] Adding configurable file size to file data visualizer * updating translated strings
walterra
reviewed
Apr 8, 2020
Contributor
walterra
left a comment
walterra
left a comment
There was a problem hiding this comment.
LGTM, added just one question about the error message.
|
|
||
| export const FileCouldNotBeRead: FC<FileCouldNotBeReadProps> = ({ error, loaded }) => { | ||
| const message = error.body.message; | ||
| const message = error?.body?.message || ''; |
Contributor
There was a problem hiding this comment.
Could we make use of getErrorMessage() from plugins/ml/common/util/errors.ts here?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the ability to override the default file size limit of 100MB to a maximum of 500MB.
A new ML specific setting can be added to the
kibana.ymlfile to achieve this.500MB has been choses as the max as it is currently the largest size the browser (tested with chrome and firefox) can handle when reading the file's contents to a string.
It would be possible to avoid creating this string and to create the uploadable chunks of documents straight from the read byte array, but this work will need to be done in a follow up PR.
Checklist
Delete any items that are not applicable to this PR.
For maintainers