[WIP] More embeddable saved object examples#62698
Closed
stacey-gammon wants to merge 2 commits intoelastic:masterfrom
Closed
[WIP] More embeddable saved object examples#62698stacey-gammon wants to merge 2 commits intoelastic:masterfrom
stacey-gammon wants to merge 2 commits intoelastic:masterfrom
Conversation
stacey-gammon
changed the title
stacey-gammon
force-pushed
the
2020-04-03-more-embed-so-examples
branch
from
f9c1837 to
e838bf4
Compare
Contributor
💔 Build Failed
Failed CI StepsHistory
To update your PR or re-run it, just comment with: |
This was referenced Apr 8, 2020
1 task
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#61692 shows a simpler example of an embeddable backed by a saved object. This builds on the changes made in that PR to show an example of how you can combine an embeddable backed by a saved object and optionally, backed by reference. It's a bit more complicated than just being backed by a saved object so I created a new example for it specifically. And since you can only have one factory per saved object type, I added a new saved object
note.