[Maps] Safely handle empty string and invalid strings from EuiColorPicker #62507
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nreese
added
release_note:fix
Team:Geo
Contributor
|
Pinging @elastic/kibana-gis (Team:Geo) |
nickpeihl
approved these changes
Apr 3, 2020
Member
nickpeihl
left a comment
nickpeihl
left a comment
There was a problem hiding this comment.
just one nit. but lgtm!
code review and tested in Chrome.
| import React, { Component } from 'react'; | ||
| import { isValidHex, EuiColorPicker, EuiFormControlLayoutProps } from '@elastic/eui'; | ||
|
|
||
| export const RGBA_0000 = 'rgba(0,0,0,0)'; |
Member
There was a problem hiding this comment.
It looks like we also have this variable in x-pack/legacy/plugins/maps/public/layers/styles/vector/properties/dynamic_color_property.js. Maybe we should add it to x-pack/plugins/maps/common/constants.ts and import from there?
Contributor
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
nreese
added a commit
to nreese/kibana
that referenced
this pull request
Apr 3, 2020
…cker (elastic#62507) * [Maps] Safely handle empty string and invalid strings from EuiColorPicker * move RGBA_0000 to constants
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Apr 6, 2020
…into event-log/query-support * 'event-log/query-support' of github.com:gmmorris/kibana: (41 commits) [jenkins] refer to sizes in most pipeline code (elastic#62082) skip flaky suite (elastic#60470) [Discover] Fix flaky FT in field visualize (elastic#62418) [ML] Data Frame Analytics: Fix feature importance (elastic#61761) [Reporting] Use a shim for server config (elastic#62086) [Reporting] Fix reporting for non-default spaces (elastic#62226) Fix bug that coerced empty scaled float value to 0 (elastic#62251) [SIEM] [Detection Engine] Remove has manage api keys requireme… (elastic#62446) [Maps] Safely handle empty string and invalid strings from EuiColorPicker (elastic#62507) Reporting/bug more blacklisted headers (elastic#62389) [SIEM] Prevent undefined behavior in our ML popover (elastic#62498) [SIEM] [Detection Engine] remove all unknowns from all rules t… (elastic#62327) base changes for active/current node styling (elastic#62007) [kbn/ui-shared-deps] expand and split (elastic#62364) [ML] DF Analytics - ensure destination index pattern created (elastic#62450) Mark rule run as failure if there was an error (elastic#62383) Add docs for metric explorer alerts (elastic#62314) skip flaky suite (elastic#62281) [SIEM][Detection Engine] Fixes export of single rule and the icons fixes flakiness (elastic#62406) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #59916
Set color to
rgba(0,0,0,0)whenever EuiColorPicker returns invalid value by way of users entering directly into the EuiColorPicker input.