Skip to content

Comments

[Maps] clean up IDynamicStyleProperty#62466

Merged
nreese merged 2 commits intoelastic:masterfrom
nreese:cleanup_IDynamicStyleProperty
Apr 6, 2020
Merged

[Maps] clean up IDynamicStyleProperty#62466
nreese merged 2 commits intoelastic:masterfrom
nreese:cleanup_IDynamicStyleProperty

Conversation

@nreese
Copy link
Contributor

@nreese nreese commented Apr 3, 2020

fixes #59914

I recommend keeping getFieldName in the interface. getField can return null so removing getFieldName would add a lot of null checks all over the code base.

#58528 removed getComputedFieldName from DynamicStyleProperty. So the only thing left was to remove the function from the interface

@nreese nreese added chore Team:Geo Former Team Label for Geo Team. Now use Team:Presentation v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.8.0 labels Apr 3, 2020
@nreese nreese requested a review from thomasneirynck April 3, 2020 15:28
@nreese nreese requested a review from a team as a code owner April 3, 2020 15:28
@elasticmachine
Copy link
Contributor

elasticmachine commented Apr 3, 2020

Pinging @elastic/kibana-gis (Team:Geo)

@nreese
Copy link
Contributor Author

nreese commented Apr 6, 2020

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

kibanamachine commented Apr 6, 2020

💚 Build Succeeded

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@nreese nreese merged commit 102fa1b into elastic:master Apr 6, 2020
nreese added a commit to nreese/kibana that referenced this pull request Apr 6, 2020
@nreese @elasticmachine
[Maps] clean up IDynamicStyleProperty (elastic#62466)
ce02c40 
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
@nreese nreese mentioned this pull request Apr 6, 2020
Merged
nreese added a commit that referenced this pull request Apr 6, 2020
@nreese @elasticmachine
[Maps] clean up IDynamicStyleProperty (#62466) (#62609)
439004b 
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@thomasneirynck thomasneirynck thomasneirynck approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

chore release_note:skip Skip the PR/issue when compiling release notes Team:Geo Former Team Label for Geo Team. Now use Team:Presentation v7.8.0 v8.0.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Maps] clean-up IDynamicStyleProperty

4 participants

@nreese @elasticmachine @kibanamachine @thomasneirynck