Conversation
|
Verbal LGTM from @BigFunger |
The problem this pr was trying to solve is caused by modules not loading their dependencies using import/require statements. When a module has Now though, plugin development is picking up and some plugins are only importing a subset of Kibana's modules (noramlly using autoloading). When those authors try to import a service like the delayed updater angular complains because it can no longer find the this is one of the benefits of the Private module loader, it requires the use of import and prevents accidentally forgetting to import services. It's still an issue for styles and directives/filters unfortunately |
|
Ironically, here is another case of this happening. This time there was again no error, angular just silently ignored the unknown render-directive element... #7629 |
Plugins created with the plugin generator import the modules they need, but some of their dependents rely on autoloading to function properly. This fixes those un-mapped dependences.