[Discover] Fix filters passing down to visualize#61392
Merged
sulemanof merged 6 commits intoelastic:masterfrom Mar 27, 2020
Merged
[Discover] Fix filters passing down to visualize#61392sulemanof merged 6 commits intoelastic:masterfrom
sulemanof merged 6 commits intoelastic:masterfrom
Conversation
7 tasks
…ers_passing # Conflicts: # test/functional/apps/discover/_field_visualize.ts
Contributor
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
Contributor
|
Pinging @elastic/kibana-app (Team:KibanaApp) |
kertal
approved these changes
Mar 26, 2020
Member
kertal
left a comment
There was a problem hiding this comment.
Code LGTM, tested locally in chrome thx for fixing this, and the functional testing of this area is so much better now 👍 !
sulemanof
added a commit
to sulemanof/kibana
that referenced
this pull request
Mar 27, 2020
* Fix visualize a discover search * Move deep clone into vis.ts * Add functional tests * Fix passing filters to visualize * Add functional tests
sulemanof
added a commit
to sulemanof/kibana
that referenced
this pull request
Mar 27, 2020
* Fix visualize a discover search * Move deep clone into vis.ts * Add functional tests * Fix passing filters to visualize * Add functional tests
sulemanof
added a commit
that referenced
this pull request
Mar 27, 2020
sulemanof
added a commit
that referenced
this pull request
Mar 27, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Based on #61226.
This fixes the next behavior:
Visualizebutton and press it;_aportion of it);The described behavior 🔼 is applicable for the query also, so this PR also adds functional test to cover both.
Checklist
Delete any items that are not applicable to this PR.
For maintainers