Skip to content

[Discover] Fix filters passing down to visualize#61392

Merged
sulemanof merged 6 commits intoelastic:masterfrom
sulemanof:fix/discover_filters_passing
Mar 27, 2020
Merged

[Discover] Fix filters passing down to visualize#61392
sulemanof merged 6 commits intoelastic:masterfrom
sulemanof:fix/discover_filters_passing

Conversation

@sulemanof
Copy link
Contributor

Summary

Based on #61226.

This fixes the next behavior:

  • create a discover search;
  • generate an app filter;
  • select a field in the sidebar which has Visualize button and press it;
  • filters should be passed down to visualize as app filters (filters should be presented at the generated url of the button in _a portion of it);

The described behavior 🔼 is applicable for the query also, so this PR also adds functional test to cover both.

Checklist

Delete any items that are not applicable to this PR.

For maintainers

…ers_passing

# Conflicts:
#	test/functional/apps/discover/_field_visualize.ts
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@sulemanof sulemanof requested review from dmlemeshko and kertal March 26, 2020 10:18
@sulemanof sulemanof added release_note:skip Skip the PR/issue when compiling release notes Team:Visualizations Team label for Lens, elastic-charts, Graph, legacy editors (TSVB, Visualize, Timelion) t// v7.7.0 v7.8.0 v8.0.0 labels Mar 26, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

@sulemanof sulemanof marked this pull request as ready for review March 26, 2020 10:19
@sulemanof sulemanof requested a review from a team March 26, 2020 10:19
Copy link
Member

@kertal kertal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM, tested locally in chrome thx for fixing this, and the functional testing of this area is so much better now 👍 !

Copy link
Contributor

@dmlemeshko dmlemeshko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sulemanof sulemanof merged commit eedf64b into elastic:master Mar 27, 2020
@sulemanof sulemanof deleted the fix/discover_filters_passing branch March 27, 2020 08:02
sulemanof added a commit to sulemanof/kibana that referenced this pull request Mar 27, 2020
* Fix visualize a discover search

* Move deep clone into vis.ts

* Add functional tests

* Fix passing filters to visualize

* Add functional tests
sulemanof added a commit to sulemanof/kibana that referenced this pull request Mar 27, 2020
* Fix visualize a discover search

* Move deep clone into vis.ts

* Add functional tests

* Fix passing filters to visualize

* Add functional tests
sulemanof added a commit that referenced this pull request Mar 27, 2020
* Fix passing filters to visualize

* Add functional tests
sulemanof added a commit that referenced this pull request Mar 27, 2020
* Fix passing filters to visualize

* Add functional tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backported release_note:skip Skip the PR/issue when compiling release notes Team:Visualizations Team label for Lens, elastic-charts, Graph, legacy editors (TSVB, Visualize, Timelion) t// v7.7.0 v7.8.0 v8.0.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants