Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect config validation on SIGHUP #61246

Merged
merged 3 commits into from
Mar 25, 2020

Conversation

rudolf
Copy link
Contributor

@rudolf rudolf commented Mar 25, 2020

Summary

Fixes #59494

Checklist

Delete any items that are not applicable to this PR.

For maintainers

applyLoggingConfiguration(settings) {
const config = new Config(this.config.getSchema(), settings);

applyLoggingConfiguration(config) {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is only called from

this.kbnServer.applyLoggingConfiguration(getLegacyRawConfig(config, pathConfig));

The only difference between this config object and the one we inject when constructing KbnServer is that this one isn't extended by the legacy plugin discovery. So it won't include any plugin config keys, but as this is used only for logging it shouldn't be a problem.

@rudolf rudolf added bug Fixes for quality problems that affect the customer experience Feature:New Platform Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc labels Mar 25, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-platform (Team:Platform)

@rudolf rudolf marked this pull request as ready for review March 25, 2020 14:38
@rudolf
Copy link
Contributor Author

rudolf commented Mar 25, 2020

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Copy link
Contributor

@joshdover joshdover left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That legacy config class is crazy, thanks for tracking this one down.

@joshdover joshdover merged commit a825fc9 into elastic:master Mar 25, 2020
joshdover pushed a commit to joshdover/kibana that referenced this pull request Mar 25, 2020
joshdover pushed a commit to joshdover/kibana that referenced this pull request Mar 25, 2020
joshdover added a commit that referenced this pull request Mar 26, 2020
joshdover added a commit that referenced this pull request Mar 26, 2020
tylersmalley pushed a commit to tylersmalley/kibana that referenced this pull request Mar 26, 2020
tylersmalley pushed a commit that referenced this pull request Mar 26, 2020
@rudolf rudolf added the blocker label Mar 26, 2020
@rudolf rudolf deleted the legacy-config-validation-on-sighup branch March 26, 2020 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocker bug Fixes for quality problems that affect the customer experience Feature:New Platform release_note:fix Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc v7.6.2 v7.7.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reloading the config breaks legacy config validation
5 participants