-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix incorrect config validation on SIGHUP #61246
Fix incorrect config validation on SIGHUP #61246
Conversation
src/legacy/server/kbn_server.js
Outdated
applyLoggingConfiguration(settings) { | ||
const config = new Config(this.config.getSchema(), settings); | ||
|
||
applyLoggingConfiguration(config) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is only called from
this.kbnServer.applyLoggingConfiguration(getLegacyRawConfig(config, pathConfig)); |
The only difference between this config object and the one we inject when constructing KbnServer is that this one isn't extended by the legacy plugin discovery. So it won't include any plugin config keys, but as this is used only for logging it shouldn't be a problem.
Pinging @elastic/kibana-platform (Team:Platform) |
@elasticmachine merge upstream |
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That legacy config class is crazy, thanks for tracking this one down.
Co-authored-by: Rudolf Meijering <[email protected]>
Co-authored-by: Rudolf Meijering <[email protected]>
Co-authored-by: Rudolf Meijering <[email protected]>
Summary
Fixes #59494
Checklist
Delete any items that are not applicable to this PR.
For maintainers