[build] Set os-packages flag on jenkins#6114
Merged
jbudz merged 1 commit intoelastic:masterfrom Feb 4, 2016
Merged
Conversation
Contributor
|
I can't get this to run successfully on my machine. I tried both node 0.12.9 and 4.2.4, but near the end it fails with: |
Contributor
Author
|
There are some dependencies listed in, https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#building-os-packages. pleaserun, fpm, rpmbuild, dpkg. Eventually automating these dependencies from an image or container would be ideal but not there yet. I have it going from a VM currently. |
Contributor
|
Ohhh, I understand. My bad! |
Contributor
|
LGTM |
jbudz
added a commit
that referenced
this pull request
Feb 4, 2016
[build] Set os-packages flag on jenkins
|
Jon Budzenski merged this into the following branches!
|
elasticsearch-bot
pushed a commit
that referenced
this pull request
Feb 4, 2016
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently on jenkins, snapshot packages are built using symlinks. When building packages we copy files instead of linking, but this was not being passed to https://github.com/elastic/kibana/blob/f97f7141e65ad79d3bded1d8c4be1a729c2e80e5/tasks/build/versionedLinks.js. Instead of passing an argument, we set the os-packages option at the start of the jenkins task.
This can be tested locally by running
grunt build --os-packagesand making surebuild/kibana*are not symlinked.