Remove "Upgrade" badge on disabled action types in the create connector flyout #61111
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YulNaumenko
added
Feature:Alerting
v8.0.0
release_note:skip
Contributor
|
Pinging @elastic/kibana-alerting-services (Team:Alerting Services) |
mikecote
reviewed
Mar 24, 2020
Contributor
mikecote
left a comment
mikecote
left a comment
There was a problem hiding this comment.
The cards endup having different heights, I wonder if @andreadelrio found a workaround for this as she also noticed the issue when no betaBadgeLabel was defined.
Contributor
|
TIL, the badge was there to solve the height differences issue. I'm looking for alternatives:
|
…pgrade-license-budge # Conflicts: # x-pack/plugins/triggers_actions_ui/public/application/sections/action_connector_form/action_type_menu.test.tsx
|
If have the banner on top with the appropriate CTA (#60698), then it should be self explanatory as to why they are not available / disabled / [whatever text we choose] |
Fix height of disabled cards
Contributor
|
PR to just add some css that fixes the height issue |
mdefazio
approved these changes
Mar 24, 2020
Contributor
mdefazio
left a comment
mdefazio
left a comment
There was a problem hiding this comment.
Thanks for the quick update on this!
Contributor
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
YulNaumenko
added a commit
to YulNaumenko/kibana
that referenced
this pull request
Mar 24, 2020
…or flyout (elastic#61111) * Remove "Upgrade" badge on disabled action types in the create connector flyout * Fix height of disabled cards Co-authored-by: defazio <[email protected]>
YulNaumenko
added a commit
that referenced
this pull request
Mar 24, 2020
…or flyout (#61111) (#61147) * Remove "Upgrade" badge on disabled action types in the create connector flyout * Fix height of disabled cards Co-authored-by: defazio <[email protected]> Co-authored-by: defazio <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve #60765