Skip to content

[es6modules] apply transforms from #6076, #6079, and #6075#6093

Merged
spalger merged 3 commits intoelastic:masterfrom
spalger:implement/es6Modules/imports
Feb 3, 2016
Merged

[es6modules] apply transforms from #6076, #6079, and #6075#6093
spalger merged 3 commits intoelastic:masterfrom
spalger:implement/es6Modules/imports

Conversation

@spalger
Copy link
Contributor

@spalger spalger commented Feb 3, 2016

No description provided.

@epixa
Copy link
Contributor

epixa commented Feb 3, 2016

I think we may have an issue with this. I tried running it locally and got this:

> ./bin/kibana --dev "--no-ssl" "--no-base-path"

 watching for changes  (100 files)
/Users/Court/p/kibana/src/cli/cluster/worker.js:33
_cluster2['default'].setupMaster({
                     ^
TypeError: undefined is not a function
    at Object.<anonymous> (/Users/Court/p/kibana/src/cli/cluster/worker.js:12:9)
    at Module._compile (module.js:460:26)
    at normalLoader (/Users/Court/p/kibana/node_modules/babel-core/lib/api/register/node.js:199:5)
    at Object.require.extensions.(anonymous function) [as .js] (/Users/Court/p/kibana/node_modules/babel-core/lib/api/register/node.js:216:7)
    at Module.load (module.js:355:32)
    at Function.Module._load (module.js:310:12)
    at Module.require (module.js:365:17)
    at require (module.js:384:17)
    at Object.<anonymous> (/Users/Court/p/kibana/src/cli/cluster/cluster_manager.js:4:25)
    at Module._compile (module.js:460:26)
 server crashed  with status code 1
/Users/Court/p/kibana/src/cli/cluster/worker.js:33
_cluster2['default'].setupMaster({
                     ^
TypeError: undefined is not a function
    at Object.<anonymous> (/Users/Court/p/kibana/src/cli/cluster/worker.js:12:9)
    at Module._compile (module.js:460:26)
    at normalLoader (/Users/Court/p/kibana/node_modules/babel-core/lib/api/register/node.js:199:5)
    at Object.require.extensions.(anonymous function) [as .js] (/Users/Court/p/kibana/node_modules/babel-core/lib/api/register/node.js:216:7)
    at Module.load (module.js:355:32)
    at Function.Module._load (module.js:310:12)
    at Module.require (module.js:365:17)
    at require (module.js:384:17)
    at Object.<anonymous> (/Users/Court/p/kibana/src/cli/cluster/cluster_manager.js:4:25)
    at Module._compile (module.js:460:26)
 optimizer crashed  with status code 1

@spalger spalger force-pushed the implement/es6Modules/imports branch from a138279 to 30ff485 Compare February 3, 2016 22:09
@spalger spalger force-pushed the implement/es6Modules/imports branch from 30ff485 to 5fa29d5 Compare February 3, 2016 22:11
@spalger
Copy link
Contributor Author

spalger commented Feb 3, 2016

@epixa the "clustering" portion of the dev server included certain code conditionally. Auto-importing everything ignored that condition and brought this error. Try things now, they seem to be working and assuming the tests pass I think we're good.

@epixa
Copy link
Contributor

epixa commented Feb 3, 2016

Kibana starts up now, and I don't notice any issues. It's hard to sort through a diff this large, but everything seems OK.

spalger added a commit that referenced this pull request Feb 3, 2016
@spalger spalger merged commit 6b9fea2 into elastic:master Feb 3, 2016
@spalger spalger deleted the implement/es6Modules/imports branch February 25, 2016 22:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants