Skip to content

Allow customLabels to be disabled on a per-agg basis#6087

Merged
rashidkpc merged 1 commit intoelastic:masterfrom
rashidkpc:fix/uselessFilterLabel
Feb 3, 2016
Merged

Allow customLabels to be disabled on a per-agg basis#6087
rashidkpc merged 1 commit intoelastic:masterfrom
rashidkpc:fix/uselessFilterLabel

Conversation

@rashidkpc
Copy link
Contributor

This adds a parameter to AggType that allows you to disable custom labels on a per-aggregation basis. This is in response to https://github.com/elastic/kibana/pull/5142/files which attaches the form to every agg. However the filters agg doesn't have a use for it.

@epixa
Copy link
Contributor

epixa commented Feb 3, 2016

LGTM

@epixa epixa assigned rashidkpc and unassigned epixa Feb 3, 2016
rashidkpc pushed a commit that referenced this pull request Feb 3, 2016
Allow customLabels to be disabled on a per-agg basis
@rashidkpc rashidkpc merged commit 353bdde into elastic:master Feb 3, 2016
@rashidkpc
Copy link
Contributor Author

thx

@rashidkpc
Copy link
Contributor Author

This can be found in the 4.x series as 5556f1a

$ git branch --contains 5556f1ad323092d892a011c45548f2086dc6eddf
  4.5
  4.5.0
  4.x

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants