es6 module - hoist private module providers#6078
Closed
spalger wants to merge 1 commit intoelastic:masterfrom
Closed
es6 module - hoist private module providers#6078spalger wants to merge 1 commit intoelastic:masterfrom
spalger wants to merge 1 commit intoelastic:masterfrom
Conversation
e499b5a to
535bfae
Compare
535bfae to
235f741
Compare
Contributor
|
Test failure |
235f741 to
a668ec9
Compare
Contributor
Author
|
resubmitting from |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Find all usage of
Private(require('...'));and convert it into two things:at the top/under the other imports of a file:
replace the original statements with: