introduce StartServicesAccessor type for CoreSetup.getStartServices#60748
Merged
pgayvallet merged 8 commits intoelastic:masterfrom Mar 24, 2020
Merged
Conversation
pgayvallet
added
Team:Core
Contributor
|
Pinging @elastic/kibana-platform (Team:Platform) |
pgayvallet
commented
Mar 20, 2020
| | [register(app)](./kibana-plugin-core-public.applicationsetup.register.md) | Register an mountable application to the system. | | ||
| | [registerAppUpdater(appUpdater$)](./kibana-plugin-core-public.applicationsetup.registerappupdater.md) | Register an application updater that can be used to change the [AppUpdatableFields](./kibana-plugin-core-public.appupdatablefields.md) fields of all applications at runtime.<!-- -->This is meant to be used by plugins that needs to updates the whole list of applications. To only updates a specific application, use the <code>updater$</code> property of the registered application instead. | | ||
| | [registerMountContext(contextName, provider)](./kibana-plugin-core-public.applicationsetup.registermountcontext.md) | Register a context provider for application mounting. Will only be available to applications that depend on the plugin that registered this context. Deprecated, use [CoreSetup.getStartServices()](./kibana-plugin-core-public.coresetup.getstartservices.md)<!-- -->. | | ||
| | [registerMountContext(contextName, provider)](./kibana-plugin-core-public.applicationsetup.registermountcontext.md) | Register a context provider for application mounting. Will only be available to applications that depend on the plugin that registered this context. Deprecated, use [CoreSetup.getStartServices](./kibana-plugin-core-public.coresetup.getstartservices.md)<!-- -->. | |
Contributor
Author
There was a problem hiding this comment.
Using a type makes the doc generator to consider it a property instead of a function and therefor generated a lot of () diff...
Comment on lines
+220
to
+222
| export type StartServicesAccessor<TPluginsStart extends object = object> = () => Promise< | ||
| [CoreStart, TPluginsStart] | ||
| >; |
Contributor
Author
There was a problem hiding this comment.
-
StartServicesAccessororCoreStartServicesAccessor? Also open to other naming suggestion -
I used
<TPluginsStart extends object = object>to be consistent withCoreSetup<TPluginsStart extends object = object>, but maybe we want<TPluginsStart extends object = {}>instead?
joshdover
approved these changes
Mar 23, 2020
Contributor
joshdover
left a comment
joshdover
left a comment
There was a problem hiding this comment.
Great idea, code looks good.
Contributor
|
Though I am a bit sad it's having to be used this much 🙁 |
Contributor
Author
Yea, I was a little surprise of the number of usages myself. PR still make sense, but we might want to take this PR's plugins code diff as a start to see if we can improve anything in our setup/start 'communication' |
…vice-accessor-type
rudolf
approved these changes
Mar 23, 2020
Contributor
I agree and we'll probably see more usage of this server-side with Elasticsearch moving to setup. |
…vice-accessor-type
…vice-accessor-type
Contributor
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
pgayvallet
added a commit
to pgayvallet/kibana
that referenced
this pull request
Mar 24, 2020
…elastic#60748) * create StartServicesAccessor type * update generated doc * update usages to use new type * add missing public annotation
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Mar 24, 2020
* master: Updating our direct usage of https-proxy-agent to 5.0.0 (elastic#58296) allow users to unset the throttle of an alert (elastic#60964) [Lens] Fix bug in metric config panel (elastic#60982) [SearchProfiler] Minor fixes (elastic#60919) [ML] Renaming ML setup and start contracts (elastic#60980) introduce StartServicesAccessor type for `CoreSetup.getStartServices` (elastic#60748) [SIEM][Detection Engine] Add rule's notification alert type (elastic#60832) [APM] Re-revert "Collect telemetry about data/API performance" (elastic#61030) [NP] Graph: get rid of saved objects class wrapper (elastic#59917) [EPM] merge duplicate fields when creating index patterns (elastic#60957) [Uptime] Ml detection of duration anomalies (elastic#59785) [Alerting] removes unimplemented buttons from Alert Details page (elastic#60934) [skip-ci] Fix CODEOWNERS paths for the Pulse team (elastic#60944) [APM] Threshold alerts (elastic#59566) [ML] Add support for percentiles aggregation to Transform wizard (elastic#60763) Cahgen save object duplicate message (elastic#60901)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
StartServicesAccessortype to avoid referencing it byCoreSetup['getStartServices']in plugin code. This is done both inpublicandserver