Resolver/nodedesign 25#60630
Resolver/nodedesign 25#60630bkimmel merged 66 commits intoelastic:masterfrom bkimmel:resolver/nodedesign_25
Conversation
… into resolver/nodedesign
| } | ||
|
|
||
| for (const treeRoot of roots) { | ||
| traverseLevels(idToAdjacent.get(uniquePidForProcess(treeRoot))!); |
There was a problem hiding this comment.
@oatkiller This is what I ended up replacing the level getter with. Should only touch each node in the tree once.
|
@oatkiller adjusted per your review. Thanks. |
|
@elasticmachine merge upstream |
There was a problem hiding this comment.
is this needed? seems like you could remove
There was a problem hiding this comment.
Typescript was whining about the function not returning anything. If you don't like the oldschool void 0 I could just make it undefined
There was a problem hiding this comment.
i think if you make the type its returning void instead of unknown it'll fix that
There was a problem hiding this comment.
that works even better; thanks @dplumlee
|
@elasticmachine merge upstream |
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
This reverts commit dd93a14.
This reverts commit 427bee4030137f7c0d99575dc847f00f08697266.
8 participants
Issue(s)
https://github.com/elastic/endpoint-app-team/issues/104
Summary
This PR adds a basic layout to build on for Resolver nodes (following the "25% zoom configuration that was laid out by @lindseypoli and @marrasherrier ") that scales with the
camerafacilities provided by the Pan/Zoom selectors and state. It incorporates EUI color palette functions for shading (and creates space for arbitrage and the provision of more complex paint servers like gradients, patterns, etc. in/defs.tsx) and an "Adjacency Map" that can be used to fulfill the navigation requirements for a "tree" as defined by https://www.w3.org/WAI/PF/aria/roles#treeAs it appears "embedded" in Alert Details:
Zoomed out:
Zoomed in:
Checklist
Delete any items that are not applicable to this PR.