[visualize] Change first chart color #6062
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Is there a reason to only replace the first seed color? Why not replace them all?
Member
Author
There was a problem hiding this comment.
Open to replacing them all, @rashidkpc any thoughts on this?
Contributor
There was a problem hiding this comment.
Do we have new seed colors to replace them with? I wasn't under the impression we did?
Member
Author
|
jenkins, test it |
jbudz
force-pushed
the
design/base_chart_color
branch
from
a0f21ec to
540a8af
Compare
Contributor
|
LGTM! |
jbudz
added a commit
that referenced
this pull request
Feb 4, 2016
[visualize] Change first chart color
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes the first color picked to #006e8a. Not sure if the seed colors need to be arranged entirely differently, thoughts?