Merged
Conversation
Contributor
|
LGTM on green build |
elasticsearch-bot
pushed a commit
that referenced
this pull request
Feb 1, 2016
elasticsearch-bot
pushed a commit
that referenced
this pull request
Feb 1, 2016
elasticsearch-bot
pushed a commit
that referenced
this pull request
Feb 1, 2016
elasticsearch-bot
pushed a commit
that referenced
this pull request
Feb 1, 2016
elasticsearch-bot
pushed a commit
that referenced
this pull request
Feb 1, 2016
elasticsearch-bot
pushed a commit
that referenced
this pull request
Feb 1, 2016
Contributor
|
You probably don't want to change it back now just for this, but FWIW this should be good re: 758c597: --- a/tasks/build/downloadNodeBuilds.js
+++ b/tasks/build/downloadNodeBuilds.js
@@ -37,7 +37,7 @@ module.exports = function (grunt) {
// use an async iife to store promise for download
// then store platform in active downloads list
// which we will read from in the finish task
- platform.downloadPromise = (async function () {
+ platform.downloadPromise = (async () => {
grunt.file.mkdir(downloadDir);
if (platform.name === 'windows') {
@@ -61,7 +61,7 @@ module.exports = function (grunt) {
await fromNode(cb => {
rename(downloadDir, finalDir, cb);
});
- }());
+ })();
activeDownloads.push(platform); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
babel-eslint includes a fix for babel/babel-eslint#243