Skip to content

[npm] upgrade babel-eslint#6060

Merged
spalger merged 2 commits intoelastic:masterfrom
spalger:upgrade/babel-eslint
Feb 1, 2016
Merged

[npm] upgrade babel-eslint#6060
spalger merged 2 commits intoelastic:masterfrom
spalger:upgrade/babel-eslint

Conversation

@spalger
Copy link
Contributor

@spalger spalger commented Feb 1, 2016

babel-eslint includes a fix for babel/babel-eslint#243

@epixa
Copy link
Contributor

epixa commented Feb 1, 2016

LGTM on green build

@epixa epixa assigned spalger and unassigned epixa Feb 1, 2016
spalger added a commit that referenced this pull request Feb 1, 2016
@spalger spalger merged commit 52fdbfa into elastic:master Feb 1, 2016
@elasticsearch-bot
Copy link

Spencer Alger merged this into the following branches!

Branch Commits
4.x e5615c9, ebf954a
4.4 33c6c5b, e7ff930
4.3 0fa7c90, ec509d6

elasticsearch-bot pushed a commit that referenced this pull request Feb 1, 2016
elasticsearch-bot pushed a commit that referenced this pull request Feb 1, 2016
elasticsearch-bot pushed a commit that referenced this pull request Feb 1, 2016
elasticsearch-bot pushed a commit that referenced this pull request Feb 1, 2016
elasticsearch-bot pushed a commit that referenced this pull request Feb 1, 2016
elasticsearch-bot pushed a commit that referenced this pull request Feb 1, 2016
@spalger spalger removed the v4.2.3 label Feb 1, 2016
@jmm
Copy link
Contributor

jmm commented Feb 1, 2016

You probably don't want to change it back now just for this, but FWIW this should be good re: 758c597:

--- a/tasks/build/downloadNodeBuilds.js
+++ b/tasks/build/downloadNodeBuilds.js
@@ -37,7 +37,7 @@ module.exports = function (grunt) {
     // use an async iife to store promise for download
     // then store platform in active downloads list
     // which we will read from in the finish task
-    platform.downloadPromise = (async function () {
+    platform.downloadPromise = (async () => {
       grunt.file.mkdir(downloadDir);

       if (platform.name === 'windows') {
@@ -61,7 +61,7 @@ module.exports = function (grunt) {
       await fromNode(cb => {
         rename(downloadDir, finalDir, cb);
       });
-    }());
+    })();

     activeDownloads.push(platform);

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants