Skip to content

Make slack param validation handle empty messages #60468

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mikecote merged 1 commit into from
Mar 19, 2020
Merged

Make slack param validation handle empty messages #60468

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion x-pack/plugins/actions/server/builtin_action_types/slack.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ const SecretsSchema = schema.object(secretsSchemaProps);
export type ActionParamsType = TypeOf<typeof ParamsSchema>;

const ParamsSchema = schema.object({
message: schema.string(),
message: schema.string({ minLength: 1 }),
});

// action type definition
Expand Down
14 changes: 14 additions & 0 deletions .../alerting_api_integration/security_and_spaces/tests/actions/builtin_action_types/slack.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -159,6 +159,20 @@ export default function slackTest({ getService }: FtrProviderContext) {
expect(result.status).to.eql('ok');
});

it('should handle an empty message error', async () => {
const { body: result } = await supertest
.post(`/api/action/${simulatedActionId}/_execute`)
.set('kbn-xsrf', 'foo')
.send({
params: {
message: '',
},
})
.expect(200);
expect(result.status).to.eql('error');
expect(result.message).to.match(/error validating action params: \[message\]: /);
});

it('should handle a 40x slack error', async () => {
const { body: result } = await supertest
.post(`/api/action/${simulatedActionId}/_execute`)
Expand Down