fix back button bug in settings app

[michaelcheng924]

This code essentially mimics the way the main tabs work. If we'd like to figure out a way to share the url function code between the different settings tabs, let me know. Just wanted to see if the direction of this possible solution is acceptable first. Closes #5982.

[ghost]

Jenkins standing by to test this. If you aren't a maintainer, you can ignore this comment. Someone with commit access, please review this and clear it for Jenkins to run; then say 'jenkins, test it'.

[Bargs]

This fixes the tabs but not the links inside any given page:

I'm wondering if there's a more universal way to solve this problem. Your code made me realize the issue had something to do with the way global state was managed. I tracked it down to the following line in this commit: 7008a51#diff-e82b59fbbd4c2cea495b7da43442f812R82

Because the hrefs in the page don't include any query params, $location.search().replace() is used which breaks the back button. I don't know why this change was made, I can't find a PR associated with the commit that changed it, so @spalger might have to enlighten us.

[michaelcheng924]

@rashidkpc This probably won't be the final solution. Just waiting on an update concerning @Bargs's observation.

[Bargs]

Need @spalger's input on why replace is being used.

[ghost]

Jenkins standing by to test this. If you aren't a maintainer, you can ignore this comment. Someone with commit access, please review this and clear it for Jenkins to run; then say 'jenkins, test it'.

[spalger]

jenkins, test it

[spalger]

While looking into this I discovered the root cause and took care of it in #6788