[7.x] [Maps] Move redux reducers and store logic to NP (#58294)#60033
Merged
kindsun merged 1 commit intoelastic:7.xfrom Mar 12, 2020
Merged
[7.x] [Maps] Move redux reducers and store logic to NP (#58294)#60033kindsun merged 1 commit intoelastic:7.xfrom
kindsun merged 1 commit intoelastic:7.xfrom
Conversation
* Plugin file and services in place. Some redux logic ported * Port and update index pattern util * Move reducers over to NP. Update refs in legacy * Port inspector to NP * Move some kibana services init to NP. Some cleaning * Clean up work not related to reducers/store * Ignore temp imports from NP. Clean up of changes unrelated to this PR * More cleanup. Check injected vars avab. before calling to handle dashboard case * Bind embeddables services the same way Maps app services bound. Create function for eventual init in NP * Call binding from constructor. Fix npStart plugins arg * Adapt changes from master * Register inspector views for embeddable. Add NP folder to i18n * Clean up. Add comments. Move inspector map view registration to NP * Remove unused inspector files in legacy * Move full screen action to legacy * Add in missing tooltip updates * Review feedback. Update constants and i18n_getters to latest in NP * Review feedback. Add redundancy comments to common files redundant in legacy and NP * Remove unneeded copy of parse xml string test in legacy * Review feedback. Remove redundant portions. Export from NP where possible. General clean up * Remove remaining refernce and case for 'TOUCH_LAYER'. It's never used
Contributor
💚 Build SucceededTo update your PR or re-run it, just comment with: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backports the following commits to 7.x: