Skip to content

Comments

[7.x] [ML] Transforms: Replace KqlFilterBar with QueryStringInput. (#59723)#60012

Merged
walterra merged 1 commit intoelastic:7.xfrom
walterra:backport/7.x/pr-59723
Mar 13, 2020
Merged

[7.x] [ML] Transforms: Replace KqlFilterBar with QueryStringInput. (#59723)#60012
walterra merged 1 commit intoelastic:7.xfrom
walterra:backport/7.x/pr-59723

Conversation

@walterra
Copy link
Contributor

Backports the following commits to 7.x:

…#59723)

- Replaces the custom KqlFilterBar with Kibana's QueryStringInput. This means the wizard now supports both lucene and kuery input.
- Using this component we no longer need to do cross-imports from the ML plugin. The use of setDependencyCache is no longer necessary.
- Replaces the custom AppDependencies provider code with Kibana's KibanaContextProvider.
@walterra walterra added the backport This PR is a backport of another PR label Mar 12, 2020
@walterra walterra self-assigned this Mar 12, 2020
@walterra walterra added the :ml label Mar 12, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@walterra walterra merged commit 6b6a7b6 into elastic:7.x Mar 13, 2020
@walterra walterra deleted the backport/7.x/pr-59723 branch March 13, 2020 07:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport This PR is a backport of another PR :ml

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants