Revert "[savedObjects] change the number mappings to be 'long'" #5983
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spalger
added a commit
that referenced
this pull request
Jan 22, 2016
Revert "[savedObjects] change the number mappings to be 'long'"
elasticsearch-bot
pushed a commit
that referenced
this pull request
Jan 22, 2016
elasticsearch-bot
pushed a commit
that referenced
this pull request
Jan 22, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #5935
Changing the mappings proved to have unexpected side-effects.
Because elasticsearch requires that all types in an index use the same field type for all fields with the same name timelion broke, because it had
hits: 'integer'in it's mapping just like it was supposed to.This isn't something plugins should have to account for in a minor (or hopefully even a major) version change.
Changing the mappings is hard, and unless there is a good reason to change them we really shouldn't. When we do get there though we will need to use migrations to properly propagate the change.