Skip to content

[7.x] [ML] Functional API tests - bucket span estimation with custom search.max_buckets (#59665) #59767

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pheyos merged 2 commits into from
Mar 11, 2020
Merged

[7.x] [ML] Functional API tests - bucket span estimation with custom search.max_buckets (#59665) #59767

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
06ee894
[ML] Functional API tests - bucket span estimation with custom search…
pheyos Mar 9, 2020
b4c85c2
Merge branch '7.x' into backport/7.x/pr-59665
elasticmachine Mar 11, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
67 changes: 64 additions & 3 deletions x-pack/test/api_integration/apis/ml/bucket_span_estimator.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ const COMMON_HEADERS = {
// eslint-disable-next-line import/no-default-export
export default ({ getService }: FtrProviderContext) => {
const esArchiver = getService('esArchiver');
const esSupertest = getService('esSupertest');
const supertest = getService('supertestWithoutAuth');
const mlSecurity = getService('mlSecurity');

Expand Down Expand Up @@ -97,8 +98,39 @@ export default ({ getService }: FtrProviderContext) => {
await esArchiver.unload('ml/ecommerce');
});

for (const testData of testDataList) {
it(`estimates the bucket span ${testData.testTitleSuffix}`, async () => {
describe('with default settings', function() {
for (const testData of testDataList) {
it(`estimates the bucket span ${testData.testTitleSuffix}`, async () => {
const { body } = await supertest
.post('/api/ml/validate/estimate_bucket_span')
.auth(testData.user, mlSecurity.getPasswordForUser(testData.user))
.set(COMMON_HEADERS)
.send(testData.requestBody)
.expect(testData.expected.responseCode);

expect(body).to.eql(testData.expected.responseBody);
});
}
});

describe('with transient search.max_buckets setting', function() {
before(async () => {
await esSupertest
.put('/_cluster/settings')
.send({ transient: { 'search.max_buckets': 9000 } })
.expect(200);
});

after(async () => {
await esSupertest
.put('/_cluster/settings')
.send({ transient: { 'search.max_buckets': null } })
.expect(200);
});

const testData = testDataList[0];

it(`estimates the bucket span`, async () => {
const { body } = await supertest
.post('/api/ml/validate/estimate_bucket_span')
.auth(testData.user, mlSecurity.getPasswordForUser(testData.user))
Expand All @@ -108,6 +140,35 @@ export default ({ getService }: FtrProviderContext) => {

expect(body).to.eql(testData.expected.responseBody);
});
}
});

describe('with persistent search.max_buckets setting', function() {
before(async () => {
await esSupertest
.put('/_cluster/settings')
.send({ persistent: { 'search.max_buckets': 9000 } })
.expect(200);
});

after(async () => {
await esSupertest
.put('/_cluster/settings')
.send({ persistent: { 'search.max_buckets': null } })
.expect(200);
});

const testData = testDataList[0];

it(`estimates the bucket span`, async () => {
const { body } = await supertest
.post('/api/ml/validate/estimate_bucket_span')
.auth(testData.user, mlSecurity.getPasswordForUser(testData.user))
.set(COMMON_HEADERS)
.send(testData.requestBody)
.expect(testData.expected.responseCode);

expect(body).to.eql(testData.expected.responseBody);
});
});
});
};