Skip to content

Downgrade to query-string v5.1.1 #59633

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Mar 13, 2020
Merged

Downgrade to query-string v5.1.1 #59633

merged 9 commits into from
Mar 13, 2020

Conversation

@alexwizp
Copy link
Contributor

@alexwizp alexwizp commented Mar 9, 2020 •
edited
Loading

Closes: #58684

Summary

In #56957, query-string 6.x was added, which does not support IE11. This needs to be downgraded in master and 7.x before the next release.

Checklist

Delete any items that are not applicable to this PR.

For maintainers

@alexwizp alexwizp self-assigned this Mar 9, 2020
@elasticmachine
Copy link
Contributor

elasticmachine commented Mar 9, 2020

Pinging @elastic/kibana-app-arch (Team:AppArch)

@alexwizp alexwizp added the release_note:skip Skip the PR/issue when compiling release notes label Mar 9, 2020
@alexwizp alexwizp marked this pull request as ready for review March 9, 2020 14:30
@alexwizp
Copy link
Contributor Author

alexwizp commented Mar 10, 2020 •
edited
Loading

@wylieconlon Could you please review that PR? I think it's less risky than revert all code

spalger
spalger reviewed Mar 10, 2020
View reviewed changes
spalger
spalger approved these changes Mar 10, 2020
View reviewed changes
Copy link
Contributor

@spalger spalger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wylieconlon
Copy link
Contributor

wylieconlon commented Mar 10, 2020

@alexwizp This approach doesn't seem to get us past the IE11 problem by itself, as less is now causing an issue. #59542

@alexwizp alexwizp requested review from a team as code owners March 11, 2020 12:06
@alexwizp
Copy link
Contributor Author

alexwizp commented Mar 11, 2020

Build is red for reasons not related to these changes

@alexwizp
Copy link
Contributor Author

alexwizp commented Mar 11, 2020

@elasticmachine merge upstream

@spalger
Copy link
Contributor

spalger commented Mar 11, 2020

I think I'm going to make this unnecessary in #59923

@spalger spalger closed this Mar 11, 2020
@spalger spalger reopened this Mar 11, 2020
@alexwizp alexwizp closed this Mar 11, 2020
@alexwizp alexwizp reopened this Mar 11, 2020
wylieconlon
wylieconlon approved these changes Mar 11, 2020
View reviewed changes
Copy link
Contributor

@wylieconlon wylieconlon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked this out and tested it in IE11. This fixes the problem.

weltenwort
weltenwort approved these changes Mar 12, 2020
View reviewed changes
Copy link
Member

@weltenwort weltenwort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

infra changes LGTM

@kibanamachine
Copy link
Contributor

kibanamachine commented Mar 12, 2020

💚 Build Succeeded

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@alexwizp
Copy link
Contributor Author

alexwizp commented Mar 12, 2020 •
edited by spalger
Loading

ping @elastic/apm-ui

lukeelmers
lukeelmers approved these changes Mar 12, 2020
View reviewed changes
Copy link
Member

@lukeelmers lukeelmers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this, @alexwizp! Looking forward to being able to upgrade in 8.0 🙂

@alexwizp
Copy link
Contributor Author

alexwizp commented Mar 13, 2020

ping @elastic/apm-ui

smith
smith approved these changes Mar 13, 2020
View reviewed changes
Copy link
Contributor

@smith smith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

APM changes look good!

@alexwizp alexwizp merged commit 9d00427 into elastic:master Mar 13, 2020
@alexwizp alexwizp mentioned this pull request Mar 13, 2020
Merged
alexwizp added a commit to alexwizp/kibana that referenced this pull request Mar 13, 2020
@alexwizp @elasticmachine
Downgrade to query-string v5.1.1 (elastic#59633)
864f828 
* Downgrade to query-string v5.1.1

* update lib version for x-pack

* fix JEST

* fix functional tests

Co-authored-by: Elastic Machine <[email protected]>
@spalger
Copy link
Contributor

spalger commented Mar 13, 2020

Thanks @alexwizp!

alexwizp added a commit that referenced this pull request Mar 13, 2020
@alexwizp @elasticmachine
Downgrade to query-string v5.1.1 (#59633) (#60107)
2371926 
* Downgrade to query-string v5.1.1

* update lib version for x-pack

* fix JEST

* fix functional tests

Co-authored-by: Elastic Machine <[email protected]>

Co-authored-by: Elastic Machine <[email protected]>
@mshustov mshustov mentioned this pull request Sep 4, 2020
Merged
@mshustov mshustov mentioned this pull request Sep 22, 2020
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@smith smith smith approved these changes

@weltenwort weltenwort weltenwort approved these changes

@lukeelmers lukeelmers lukeelmers approved these changes

+2 more reviewers

@wylieconlon wylieconlon wylieconlon approved these changes

@spalger spalger spalger approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@alexwizp alexwizp

Labels

release_note:skip Skip the PR/issue when compiling release notes v7.7.0 v8.0.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Downgrade to query-string v5.1.1

8 participants

@alexwizp @elasticmachine @wylieconlon @spalger @kibanamachine @smith @weltenwort @lukeelmers