Skip to content

[7.x] Check for alert dialog when doing a force logout (#59329) #59593

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
brianseeders merged 2 commits into from
Mar 10, 2020
Merged

[7.x] Check for alert dialog when doing a force logout (#59329) #59593

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
106b71f
Check for alert dialog when doing a force logout (#59329)
brianseeders Mar 6, 2020
7c06580
Merge branch '7.x' into backport/7.x/pr-59329
elasticmachine Mar 9, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 12 additions & 11 deletions x-pack/test/functional/page_objects/security_page.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,12 +110,7 @@ export function SecurityPageProvider({ getService, getPageObjects }) {
}

await userMenu.clickLogoutButton();

await retry.waitForWithTimeout(
'login form',
config.get('timeouts.waitFor') * 5,
async () => await find.existsByDisplayedByCssSelector('.login-form')
);
await this.waitForLoginForm();
}

async forceLogout() {
Expand All @@ -129,11 +124,17 @@ export function SecurityPageProvider({ getService, getPageObjects }) {
const url = PageObjects.common.getHostPort() + '/logout';
await browser.get(url);
log.debug('Waiting on the login form to appear');
await retry.waitForWithTimeout(
'login form',
config.get('timeouts.waitFor') * 5,
async () => await find.existsByDisplayedByCssSelector('.login-form')
);
await this.waitForLoginForm();
}

async waitForLoginForm() {
await retry.waitForWithTimeout('login form', config.get('timeouts.waitFor') * 5, async () => {
const alert = await browser.getAlert();
if (alert && alert.accept) {
await alert.accept();
}
return await find.existsByDisplayedByCssSelector('.login-form');
});
}

async clickRolesSection() {
Expand Down