Skip to content

Comments

[Maps] Update layer dependencies to NP#59585

Merged
kindsun merged 17 commits intoelastic:masterfrom
kindsun:np-update-layer-dependencies
Mar 20, 2020
Merged

[Maps] Update layer dependencies to NP#59585
kindsun merged 17 commits intoelastic:masterfrom
kindsun:np-update-layer-dependencies

Conversation

@kindsun
Copy link
Contributor

@kindsun kindsun commented Mar 6, 2020 •
edited
Loading

Prepare Maps layers and related files for migration. This PR accomplishes the following:

  • Adds a separate bindStartCoreAndPlugins function for initializing NP services
  • Set required NP services in kibana_services
  • Update legacy dependencies to their NP equivalents in layers dir
  • Update affected jest tests and remove legacy refs. Functional tests were also checked but not affected by this work

A couple things to note:

  • I pulled the functions from ui/vis/map/color_util into the Maps app in our own color_utils file. These functions are only leveraged 2 places, in Maps and Legacy Maps. I'll likely do the same thing in legacy Maps soon as well. I believe the benefit of the shared code is outweighed by 2 facts, legacy Maps is getting deprecated, and it's an unnecessary overhead dependency to do a separate migration for these small utility functions which may or may not have a good home in NP in the long run
  • I've tested this code out fully moved to the NP (unlike in this PR where it's still in legacy) and it worked as expected

@kindsun kindsun added Team:Geo Former Team Label for Geo Team. Now use Team:Presentation v8.0.0 Feature:NP Migration v7.7.0 labels Mar 6, 2020
@elasticmachine
Copy link
Contributor

elasticmachine commented Mar 6, 2020

Pinging @elastic/kibana-gis (Team:Geo)

This was referenced Mar 6, 2020
Closed
Merged
@kindsun kindsun force-pushed the np-update-layer-dependencies branch from ea725dd to 504a572 Compare March 16, 2020 22:17
Aaron Caldwell added 13 commits March 17, 2020 10:00
Create separate init method for plugin setup, leverage in embeddable …
8906c4c 
…factory
Add NP timefilter, http, IndexPatternSelect
6654914
Merge remote-tracking branch 'upstream/master' into np-update-layer-d…
ccfc1ed 
…ependencies
Pull vis color utils into Maps
be6bdd5
Add NP dark mode and toast handling. Some fixes
223c876
Init autocomplete and indexPattern via normal paths
6335ab4
Test fixes and clean up
09557bb
Update index pattern and autocomplete refs. Make getters functions
bb30b0a
Fix remaining broken jest tests
6bcf095
Update inspector start contract
a901ae9
Clean up plugin and legacy files. Fix type issues
43efb9c
Merge remote-tracking branch 'upstream/master' into np-update-layer-d…
eb76efe 
…ependencies
Set inspector in plugin start method not external function
b07589b
@kindsun kindsun force-pushed the np-update-layer-dependencies branch from 1bbd992 to b07589b Compare March 18, 2020 21:20
@kindsun kindsun marked this pull request as ready for review March 19, 2020 18:59
@kindsun kindsun requested a review from a team as a code owner March 19, 2020 18:59
@kindsun kindsun added the release_note:skip Skip the PR/issue when compiling release notes label Mar 19, 2020
@kindsun
Copy link
Contributor Author

kindsun commented Mar 19, 2020

retest

nreese
nreese approved these changes Mar 19, 2020
View reviewed changes
Copy link
Contributor

@nreese nreese left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice design to break the work into a prep phase and then a migration phase. This will make it easier to avoid merge conflicts. Lets just make sure we talk about about current in-flight PRs when discussing migration phase timing

lgtm with green CI
code review

@kibanamachine
Copy link
Contributor

kibanamachine commented Mar 19, 2020

💚 Build Succeeded

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@kindsun kindsun merged commit 592ded8 into elastic:master Mar 20, 2020
@kindsun kindsun mentioned this pull request Mar 20, 2020
Merged
kindsun pushed a commit to kindsun/kibana that referenced this pull request Mar 20, 2020
[Maps] Update layer dependencies to NP (elastic#59585)
f4f83a1 
* Layers dir up through sources migrated. Kibana services updated

* Create separate init method for plugin setup, leverage in embeddable factory

* Add NP timefilter, http, IndexPatternSelect

* Pull vis color utils into Maps

* Add NP dark mode and toast handling. Some fixes

* Init autocomplete and indexPattern via normal paths

* Test fixes and clean up

* Update index pattern and autocomplete refs. Make getters functions

* Fix remaining broken jest tests

* Update inspector start contract

* Clean up plugin and legacy files. Fix type issues

* Set inspector in plugin start method not external function

* Keep both injected var functions (legacy and NP). Move inspector init back to separate init function

* Add back ts-ignore on NP kibana services import
gmmorris added a commit to gmmorris/kibana that referenced this pull request Mar 20, 2020
@gmmorris
Merge branch 'master' into alerting/api-constant
377acfc 
* master: (52 commits)
  [SIEM] Fix types in rules tests (elastic#60736)
  [Alerting] prevent flickering when fields are updated in an alert (elastic#60666)
  License checks for actions plugin (elastic#59070)
  Implemented ability to clear and properly validate alert interval (elastic#60571)
  WebElementWrapper: add findByTestSubject/findAllByTestSubject to search with data-test-subj (elastic#60568)
  [Maps] Update layer dependencies to NP (elastic#59585)
  [Discover] Remove StateManagementConfigProvider (elastic#60221)
  [ML] Listing all categorization wizard checks (elastic#60502)
  [Upgrade Assistant] First iteration of batch reindex docs (elastic#59887)
  [SIEM] Export timeline (elastic#58368)
  [SIEM] Add support for actions and throttle in Rules (elastic#59641)
  Fix ace a11y listener (elastic#60639)
  Add addInfo toast to core notifications service (elastic#60574)
  fix test description (elastic#60638)
  [SIEM] Cypress screenshots upload to google cloud (elastic#60556)
  [canvas/shareable_runtime] sync sass loaders with kbn/optimizer (elastic#60653)
  [SIEM] Fixes Modification of ML Rules (elastic#60662)
  [SIEM] [Case] Bulk status update, add comment avatar, id => title in breadcrumbs (elastic#60410)
  [Alerting] add functional tests for index threshold alertType (elastic#60597)
  [Ingest]EMT-248: add post action request handler and resources (elastic#60581)
  ...
kindsun pushed a commit that referenced this pull request Mar 20, 2020
[Maps] Update layer dependencies to NP (#59585) (#60753)
e466309 
* Layers dir up through sources migrated. Kibana services updated

* Create separate init method for plugin setup, leverage in embeddable factory

* Add NP timefilter, http, IndexPatternSelect

* Pull vis color utils into Maps

* Add NP dark mode and toast handling. Some fixes

* Init autocomplete and indexPattern via normal paths

* Test fixes and clean up

* Update index pattern and autocomplete refs. Make getters functions

* Fix remaining broken jest tests

* Update inspector start contract

* Clean up plugin and legacy files. Fix type issues

* Set inspector in plugin start method not external function

* Keep both injected var functions (legacy and NP). Move inspector init back to separate init function

* Add back ts-ignore on NP kibana services import
gmmorris added a commit to gmmorris/kibana that referenced this pull request Mar 20, 2020
@gmmorris
Merge branch 'master' into alerting/empty-list
e8c7be8 
* master: (55 commits)
  Update dependency @elastic/charts to v18.1.0 (elastic#60578)
  Only set timezone when user setting is a valid timezone (elastic#57850)
  [NP] Remove `ui/agg_types` dependencies and move paginated table to kibana_legacy (elastic#60276)
  [SIEM] Fix types in rules tests (elastic#60736)
  [Alerting] prevent flickering when fields are updated in an alert (elastic#60666)
  License checks for actions plugin (elastic#59070)
  Implemented ability to clear and properly validate alert interval (elastic#60571)
  WebElementWrapper: add findByTestSubject/findAllByTestSubject to search with data-test-subj (elastic#60568)
  [Maps] Update layer dependencies to NP (elastic#59585)
  [Discover] Remove StateManagementConfigProvider (elastic#60221)
  [ML] Listing all categorization wizard checks (elastic#60502)
  [Upgrade Assistant] First iteration of batch reindex docs (elastic#59887)
  [SIEM] Export timeline (elastic#58368)
  [SIEM] Add support for actions and throttle in Rules (elastic#59641)
  Fix ace a11y listener (elastic#60639)
  Add addInfo toast to core notifications service (elastic#60574)
  fix test description (elastic#60638)
  [SIEM] Cypress screenshots upload to google cloud (elastic#60556)
  [canvas/shareable_runtime] sync sass loaders with kbn/optimizer (elastic#60653)
  [SIEM] Fixes Modification of ML Rules (elastic#60662)
  ...
gmmorris added a commit to gmmorris/kibana that referenced this pull request Mar 20, 2020
@gmmorris
Merge branch 'master' into alerting/tls-warning
5a5c8a4 
* master:
  Only set timezone when user setting is a valid timezone (elastic#57850)
  [NP] Remove `ui/agg_types` dependencies and move paginated table to kibana_legacy (elastic#60276)
  [SIEM] Fix types in rules tests (elastic#60736)
  [Alerting] prevent flickering when fields are updated in an alert (elastic#60666)
  License checks for actions plugin (elastic#59070)
  Implemented ability to clear and properly validate alert interval (elastic#60571)
  WebElementWrapper: add findByTestSubject/findAllByTestSubject to search with data-test-subj (elastic#60568)
  [Maps] Update layer dependencies to NP (elastic#59585)
  [Discover] Remove StateManagementConfigProvider (elastic#60221)
@nreese nreese mentioned this pull request Mar 24, 2020
Closed
@kindsun kindsun mentioned this pull request Mar 30, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nreese nreese nreese approved these changes

+1 more reviewer

@thomasneirynck thomasneirynck thomasneirynck approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Feature:NP Migration release_note:skip Skip the PR/issue when compiling release notes Team:Geo Former Team Label for Geo Team. Now use Team:Presentation v7.7.0 v8.0.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@kindsun @elasticmachine @kibanamachine @nreese @thomasneirynck