[7.x] [APM] Create settings page to manage Custom Links (#57788)#59535
Merged
cauemarcondes merged 2 commits intoelastic:7.xfrom Mar 9, 2020
Merged
[7.x] [APM] Create settings page to manage Custom Links (#57788)#59535cauemarcondes merged 2 commits intoelastic:7.xfrom
cauemarcondes merged 2 commits intoelastic:7.xfrom
Conversation
* creating custom action index * reverting service form to service section * creating useForm hooks and fields section * adding react-hook-form * refactoring * validating filters * fixing imports * refactoring to NP and creating save custom action * creating basic apis for custom actions * refactoring * changing custom action filters type * adding delete option * removing useForm * fixing flyout view * filters are invalid when selecting the default value * ui fixes * ui fixes * fixing typescript * fixing typescript * fixing labels and adding space btw components * refactoring filters structure * removing reach-hook-form * removing reach-hook-form * adding unit tests * adding unit tests * create custom action index * adding filter option * refactoring create index, creating filter links * creating list api * rename custom action to custom link * fixing unit tests * adding unit tests * refactoring callApmApi * removing useCallApmApi hook * Rename Flyoutfooter.tsx to FlyoutFooter.tsx * removing unused import * fixing typescript errors * fixing duplicate messages * removing filters * fixing save functionality * fixing pr comments * fixing pr comments
Contributor
Author
|
retest |
Contributor
Author
|
@elasticmachine merge upstream |
Contributor
Author
|
jenkins, retest this please |
Contributor
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backports the following commits to 7.x: