[SR] Selected indices do not show when editing a policy created via console by jkelastic · Pull Request #59486 · elastic/kibana

jkelastic · 2020-03-05T21:58:15Z

Summary

Fixes #47156 Rename index pattern to custom pattern and default to customer pattern page

Checklist

Use ~~strikethroughs~~ to remove checklist items you don't feel are applicable to this PR.

This was checked for cross-browser compatibility, including a check against IE11
~~Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support~~
~~Documentation was added for features that require explanation or tutorials~~
Unit or functional tests were updated or added to match the most common scenarios
~~This was checked for keyboard-only and screenreader accessibility~~

For maintainers

This was checked for breaking API changes and was labeled appropriately
This includes a feature addition or change that requires a release note and was labeled appropriately

Release note

This PR resolves an issue where the indices of a Snapshot Lifecycle Policy were not always displayed correctly in the Snapshot & Restore UI when editing an existing policy.

elasticmachine · 2020-03-05T21:59:41Z

Pinging @elastic/es-ui (Team:Elasticsearch UI)

alisonelizabeth · 2020-03-06T16:04:47Z

Hi @jkelastic! Can you please take another look at this one? It looks like the code is referencing an import that does not exist anymore and the settings step no longer loads.

cla-checker-service · 2020-03-11T19:54:45Z

💚 CLA has been signed

alisonelizabeth · 2020-03-16T15:29:30Z

@jkelastic looks like there are still some problems here. Can you take a look? Once it's been resolved and you have tested the changes, please let know and I will review the PR again. Let me know if you need any help. Thanks!

jkelastic · 2020-03-24T17:13:03Z

closing temporarily as I'm short on time to make this for 7.7, will reopen later

…ns path and Eslint fix

alisonelizabeth

Hi @jkelastic. Thanks for picking this one back up! I didn't test your changes yet, but I did notice a few issues in the translation file. Can you take a look? I believe you should only need to delete xpack.snapshotRestore.policyValidation.indexPatternRequiredErrorMessage; the rest of the translation file should remain the same.

alisonelizabeth · 2020-08-05T03:16:44Z

x-pack/plugins/translations/translations/ja-JP.json

    "kbn.advancedSettings.storeUrlTitle": "セッションストレージに URL を格納",
    "kbn.advancedSettings.themeVersionText": "現在のバージョンと次のバージョンのKibanaで使用されるテーマを切り替えます。この設定を適用するにはページの更新が必要です。",
    "kbn.advancedSettings.themeVersionTitle": "テーマバージョン",
-    "kbn.advancedSettings.timepicker.timeDefaultsText": "時間フィルターが選択されずに Kibana が起動した際に使用される時間フィルターです",


This seems unrelated to your change; I don't think it should be deleted.

@alisonelizabeth I think my local master branch is out of sync. After adding back the translations I'm no longer getting unused translation.

alisonelizabeth · 2020-08-05T03:16:49Z

x-pack/plugins/translations/translations/ja-JP.json

    "kbn.advancedSettings.themeVersionText": "現在のバージョンと次のバージョンのKibanaで使用されるテーマを切り替えます。この設定を適用するにはページの更新が必要です。",
    "kbn.advancedSettings.themeVersionTitle": "テーマバージョン",
-    "kbn.advancedSettings.timepicker.timeDefaultsText": "時間フィルターが選択されずに Kibana が起動した際に使用される時間フィルターです",
-    "kbn.advancedSettings.timepicker.timeDefaultsTitle": "デフォルトのタイムピッカー",


Same here, everything looks good.

alisonelizabeth · 2020-08-05T03:18:51Z

x-pack/plugins/translations/translations/ja-JP.json

    "xpack.watcher.watcherDescription": "アラートの作成、管理、監視によりデータへの変更を検知します。"
  }
-}
+}


can you add back the new line at the end of the file?

Same here, everything looks good.

alisonelizabeth · 2020-08-05T12:41:28Z

x-pack/plugins/translations/translations/ja-JP.json

    "xpack.ml.newJob.wizard.jobDetailsStep.advancedSection.enableModelPlotAnnotations.description": "選択すると、モデルが大幅に変更されたときに注釈を生成します。たとえば、ステップが変更されると、期間や傾向が検出されます。",
    "xpack.ml.newJob.wizard.jobDetailsStep.advancedSection.enableModelPlotAnnotations.title": "モデル変更注釈を有効にする",
-    "xpack.ml.newJob.wizard.jobDetailsStep.advancedSection.mmlWarning.message": "モデルプロットの作成には大量のリソースを消費する可能性があり、選択されたフィールドの基数が100を超える場合はお勧めしません。このジョブの予測基数は{highCardinality}です。 この構成でモデルプロットを有効にする場合、専用の結果インデックスを選択することをお勧めします。",
+    "xpack.ml.newJob.wizard.jobDetailsStep.advancedSection.mmlWarning.message": "モデルプロットの作成には大量のリソースを消費する可能性があり、選択されたフィールドの基数が100を超える場合はお勧めしません。このジョブの予測基数は{highCardinality}です。 この構成でモデルプロットを有効にする場合、専用の結果インデックスを選択することをお勧めします。",


I'm not sure why there's a diff here. I think we should try to leave any translations not related to your changes as-is.

Will do, thanks.

jkelastic · 2020-08-05T17:59:46Z

@elasticmachine merge upstream

jkelastic · 2020-08-29T14:37:18Z

@elasticmachine merge upstream

kibanamachine · 2020-08-29T16:28:35Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: 80645c8

Build metrics

async chunks size

id	value	diff	baseline
snapshotRestore	758.0KB	-215.0B	758.2KB

History

💚 Build #66705 succeeded 2252e05
💚 Build #66667 succeeded e536c3d
💚 Build #66295 succeeded 114c3c2
💔 Build #66269 failed c7d2705
💔 Build #66213 failed feddba1

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

alisonelizabeth

Hi @jkelastic! After looking at the code again, I'm not sure the original bug is relevant anymore. I'm going to assign @jloleysens to take a look and confirm. He's made some changes to this area of the code to support data streams, and is probably more familiar than I at this point.

jkelastic · 2020-08-31T15:29:44Z

Hi @jkelastic! After looking at the code again, I'm not sure the original bug is relevant anymore. I'm going to assign @jloleysens to take a look and confirm. He's made some changes to this area of the code to support data streams, and is probably more familiar than I at this point.

@alisonelizabeth thank you ^^

alisonelizabeth · 2020-09-30T18:17:58Z

Hi @jkelastic! I verified that I'm no longer able to reproduce this issue on master, so I'm going to go ahead and close the issue and this PR.

jkelastic · 2020-10-01T14:43:20Z

Hi @jkelastic! I verified that I'm no longer able to reproduce this issue on master, so I'm going to go ahead and close the issue and this PR.

@alisonelizabeth thank you

jkelastic mentioned this pull request Mar 5, 2020

[SR] Selected indices do not show when editing a policy created via console #55219

Closed

4 tasks

jkelastic added v7.7.0 v8.0.0 Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more t// labels Mar 5, 2020

jkelastic added release_note:fix Feature:Snapshot and Restore Elasticsearch snapshots and repositories UI labels Mar 5, 2020

alisonelizabeth self-requested a review March 6, 2020 02:29

jkelastic requested review from a team as code owners March 11, 2020 19:54

jkelastic force-pushed the bugfix/Snapshot_plugin_restore_custom_pattern branch 2 times, most recently from 9eb1596 to 9b84595 Compare March 12, 2020 21:25

mshustov removed the request for review from a team March 13, 2020 17:14

jkelastic closed this Mar 24, 2020

jkelastic reopened this Aug 3, 2020

jkelastic added v7.10.0 and removed v7.7.0 labels Aug 3, 2020

jkelastic added 2 commits August 3, 2020 11:57

Updating files with same changes after move from legacy path to plugi…

68aec11

…ns path and Eslint fix

Eslint fix

3545c8d

jkelastic force-pushed the bugfix/Snapshot_plugin_restore_custom_pattern branch from d627633 to 3545c8d Compare August 3, 2020 19:02

jkelastic requested a review from a team as a code owner August 3, 2020 19:02

jkelastic added 4 commits August 3, 2020 12:33

Added back string type

feddba1

Undo changes and revert back to master copy and Eslint fix

c7d2705

Remove unused translations

d53d5fc

Remove unused translations

114c3c2

alisonelizabeth removed the request for review from a team August 5, 2020 03:13

alisonelizabeth requested changes Aug 5, 2020

View reviewed changes

Addeed back translations

e536c3d

Merge branch 'master' into bugfix/Snapshot_plugin_restore_custom_pattern

2252e05

Merge branch 'master' into bugfix/Snapshot_plugin_restore_custom_pattern

80645c8

alisonelizabeth reviewed Aug 31, 2020

View reviewed changes

alisonelizabeth requested a review from jloleysens August 31, 2020 15:07

alisonelizabeth closed this Sep 30, 2020

Conversation

jkelastic commented Mar 5, 2020

Summary

Checklist

For maintainers

Release note

Uh oh!

elasticmachine commented Mar 5, 2020

Uh oh!

alisonelizabeth commented Mar 6, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cla-checker-service bot commented Mar 11, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

alisonelizabeth commented Mar 16, 2020

Uh oh!

jkelastic commented Mar 24, 2020

Uh oh!

alisonelizabeth left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jkelastic commented Aug 5, 2020

Uh oh!

jkelastic commented Aug 29, 2020

Uh oh!

kibanamachine commented Aug 29, 2020

💚 Build Succeeded

Build metrics

async chunks size

History

Uh oh!

alisonelizabeth left a comment

Choose a reason for hiding this comment

Uh oh!

jkelastic commented Aug 31, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

alisonelizabeth commented Sep 30, 2020

Uh oh!

jkelastic commented Oct 1, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

alisonelizabeth commented Mar 6, 2020 •

edited

Loading

cla-checker-service bot commented Mar 11, 2020 •

edited

Loading

jkelastic commented Aug 31, 2020 •

edited

Loading