[savedObjects] change the number mappings to be 'long'#5934
Merged
spalger merged 1 commit intoelastic:4.3from Jan 20, 2016
Merged
[savedObjects] change the number mappings to be 'long'#5934spalger merged 1 commit intoelastic:4.3from
spalger merged 1 commit intoelastic:4.3from
Conversation
Contributor
Author
|
Issued as a separate PR to verify that tests pass. |
spalger
added a commit
that referenced
this pull request
Jan 20, 2016
[savedObjects] change the number mappings to be 'long'
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since JavaScript numbers can't actually be integers we don't really
care about the difference between int and long, but since the long
is the default type it makes things more frictionless
Original
issue: #3882
commit: 1b9a646
author: @spalger
This change went into 4.1 but was somehow left out of 4.2 onward.