Skip to content

Check for alert dialog when doing a force logout #59329

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
brianseeders merged 7 commits into from
Mar 6, 2020
Merged

Check for alert dialog when doing a force logout #59329

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
8eaa2ca
Check for alert dialog when doing a force logout
brianseeders Mar 4, 2020
85f5831
Merge branch 'master' into fix/force-logout-check-alert
elasticmachine Mar 4, 2020
5d3b25a
Merge remote-tracking branch 'upstream/master' into fix/force-logout-…
brianseeders Mar 5, 2020
ceaaef8
Add missing await
brianseeders Mar 5, 2020
9437d37
Merge branch 'fix/force-logout-check-alert' of github.com:brianseeder…
brianseeders Mar 5, 2020
6a592da
Merge branch 'master' into fix/force-logout-check-alert
elasticmachine Mar 6, 2020
f665b23
Merge branch 'master' into fix/force-logout-check-alert
elasticmachine Mar 6, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 12 additions & 11 deletions x-pack/test/functional/page_objects/security_page.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,12 +110,7 @@ export function SecurityPageProvider({ getService, getPageObjects }) {
}

await userMenu.clickLogoutButton();

await retry.waitForWithTimeout(
'login form',
config.get('timeouts.waitFor') * 5,
async () => await find.existsByDisplayedByCssSelector('.login-form')
);
await this.waitForLoginForm();
}

async forceLogout() {
Expand All @@ -129,11 +124,17 @@ export function SecurityPageProvider({ getService, getPageObjects }) {
const url = PageObjects.common.getHostPort() + '/logout';
await browser.get(url);
log.debug('Waiting on the login form to appear');
await retry.waitForWithTimeout(
'login form',
config.get('timeouts.waitFor') * 5,
async () => await find.existsByDisplayedByCssSelector('.login-form')
);
await this.waitForLoginForm();
}

async waitForLoginForm() {
await retry.waitForWithTimeout('login form', config.get('timeouts.waitFor') * 5, async () => {
const alert = await browser.getAlert();
if (alert && alert.accept) {
await alert.accept();
}
return await find.existsByDisplayedByCssSelector('.login-form');
});
}

async clickRolesSection() {
Expand Down