Closed
Conversation
4f3b0f6 to
00b2c3c
Compare
spalger
reviewed
Mar 10, 2020
Contributor
|
Pinging @elastic/kibana-security (Team:Security) |
00b2c3c to
bbcd78d
Compare
bbcd78d to
3c3e59a
Compare
Contributor
💛 Build succeeded, but was flaky
Test FailuresKibana Pipeline / kibana-oss-agent / Chrome UI Functional Tests.test/functional/apps/management/_handle_alias·js.management Index patterns on aliases should be able to discover and verify no of hits for alias2Standard OutStack TraceHistory
To update your PR or re-run it, just comment with: |
spalger
approved these changes
Mar 12, 2020
Contributor
spalger
left a comment
There was a problem hiding this comment.
LGTM, flaky test was skipped in master recently.
Contributor
|
do u mind adjusting the labels @watson , I see this is still a draft PR, but has 7.17.1 label which is going out today. Thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on #55697 - Once that lands, I'll rebase this PR at which time only the last commit is relevant.This PR was originally part of #55697 - for the previous discussion about this code, see that PR.
This PR hardens the
process.envproperty to not be susceptible to prototype pollution fromObject.prototype.