Fix multiple problems with discover 'should show the correct bar char…#5919
Merged
LeeDr merged 3 commits intoelastic:masterfrom Jan 15, 2016
Merged
Fix multiple problems with discover 'should show the correct bar char…#5919LeeDr merged 3 commits intoelastic:masterfrom
LeeDr merged 3 commits intoelastic:masterfrom
Conversation
…t'. UTC timezone, array.length, improve cssSelector.
Contributor
|
jenkins, test it |
1 similar comment
Author
|
jenkins, test it |
Contributor
|
👍 , after jenkins passes this LGTM |
LeeDr
pushed a commit
that referenced
this pull request
Jan 15, 2016
Fix multiple problems with discover 'should show the correct bar char…
LeeDr
pushed a commit
that referenced
this pull request
Jan 15, 2016
Merge #5919 to Fix discover test v4.x
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
One discover test wasn't really checking the data.