Skip to content

[7.x] Move dev tools styles to NP (#58855) #58973

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
maryia-lapata merged 1 commit into from
Mar 1, 2020
Merged

[7.x] Move dev tools styles to NP (#58855) #58973

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion src/legacy/core_plugins/kibana/public/dev_tools/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
This folder is just a left-over of the things that can't be moved to Kibana platform just yet:

* Styling (this can be moved as soon as there is support for styling in Kibana platform)
* Check whether there are no dev tools and hide the link in the nav bar (this can be moved as soon as all dev tools are moved)
3 changes: 0 additions & 3 deletions src/legacy/core_plugins/kibana/public/index.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,9 +10,6 @@
// vis_type_vislib UI styles
@import 'src/legacy/core_plugins/vis_type_vislib/public/index';

// Dev tools styles
@import './dev_tools/index';

// Discover styles
@import 'discover/index';

Expand Down
0 ...ugins/kibana/public/dev_tools/_index.scss → src/plugins/dev_tools/public/index.scss
View file
Open in desktop
File renamed without changes.
2 changes: 2 additions & 0 deletions src/plugins/dev_tools/public/plugin.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,8 @@ import { App, CoreSetup, Plugin } from 'kibana/public';
import { sortBy } from 'lodash';
import { KibanaLegacySetup } from '../../kibana_legacy/public';

import './index.scss';

export interface DevToolsSetup {
/**
* Register a developer tool. It will be available
Expand Down