Date Range Agg - key needs to be a string

[majagrubic]

Summary

Attempt at fixing: #57122.

The problem here is that d3 cannot take domain in the form {from, to}:
https://github.com/elastic/kibana/blob/master/src/legacy/core_plugins/vis_type_vislib/public/vislib/lib/axis/axis_scale.js#L246
It expect a value or an array. (Credits to Marco for figuring this out). This breaks the scale calculation and was probably introduced in this PR:
#48090

I think the reasonable solution would be to return to the previous state, ie. returning string key instead of an object. I'm not sure what are the implications of doing this and if something else would break. I tested this on the vertical bar with Date Range on X-Axis.

Before:

After:

Let me know what you think and if it's ok to continue down this path.

Checklist

Delete any items that are not applicable to this PR.

• Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
• Documentation was added for features that require explanation or tutorials
• Unit or functional tests were updated or added to match the most common scenarios
• This was checked for keyboard-only and screenreader accessibility
• This renders correctly on smaller devices using a responsive layout. (You can test this in your browser
• This was checked for cross-browser compatibility, including a check against IE11

For maintainers

• This was checked for breaking API changes and was labeled appropriately

[flash1293]

You are completely right @majagrubic , that's the PR which caused the bug. I would recommend not to revert the change though because we need access to the raw object of the range to be able to correctly build the filter when clicking a bar / pie slice in a chart in src/legacy/core_plugins/vis_type_vislib/public/vislib/lib/dispatch.js

If you want to continue to look into this (happy to take it over if you want), I would recommend trying to stringify the value somehow to make it compatible with d3, e.g. before passing it into https://github.com/elastic/kibana/blob/master/src/legacy/core_plugins/vis_type_vislib/public/vislib/lib/axis/axis_scale.js#L246

[kibanamachine]

💔 Build Failed

• continuous-integration/kibana-ci/pull-request
• Commit: 71e4ff8

History

• 💔 Build #33541 failed e2198fc
• 💔 Build #29845 failed 096668d

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream