[ML] Fixing annotations alias checks

[jgowdyelastic]

Fixes bug caused by the changing of ml-annotations-read and ml-annotations-write to hidden indices (elastic/elasticsearch#52423) which made it impossible to create annotations when security is disabled.

When calling indices.existsAlias we now need to specify index and name.

[elasticmachine]

Pinging @elastic/ml-ui (:ml)

[peteharverson]

LGTM

[droberts195]

when security is disabled

I think this is actually a sign of another bug, alluded to in "We're likely going to have to make some improvements to how Security handles aliases" in elastic/elasticsearch#52304 (comment). Logically the problem being fixed here should have happened both with security enabled and disabled.

/cc @jaymode and @gwbrown to make sure your plans for elastic/elasticsearch#52304 cover this. The discrepancy happened when checking for the existence of an alias by asking if it is an alias of any index:

• When the alias was an alias on a hidden index and security was disabled the API call said the alias didn't exist
• When the alias was an alias on a hidden index and security was enabled the API call said the alias did exist

[jgowdyelastic]

@elasticmachine merge upstream

[gwbrown]

Thanks @droberts195, I'll make sure we have integration tests for those scenarios so that they behave the same.

[darnautov]

LGTM

[walterra]

LGTM

[kibanamachine]

💚 Build Succeeded

• continuous-integration/kibana-ci/pull-request
• Commit: a7aedd8

History

• 💚 Build #29443 succeeded 49a795cc2e49eff6f6f614e2f496e8bfcc33af72

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream