[Metric Alerts] Add backend support for multiple expressions per alert #58672
Merged
Zacqary merged 4 commits intoelastic:masterfrom Feb 28, 2020
Merged
[Metric Alerts] Add backend support for multiple expressions per alert #58672Zacqary merged 4 commits intoelastic:masterfrom
Zacqary merged 4 commits intoelastic:masterfrom
Conversation
Zacqary
added
Feature:Alerting
Feature:Metrics UI
Contributor
|
Pinging @elastic/logs-metrics-ui (Team:logs-metrics-ui) |
Zacqary
force-pushed
the
58669-multiple-alert-expressions
branch
from
02236a6 to
996f7ea
Compare
phillipb
suggested changes
Feb 27, 2020
Contributor
phillipb
left a comment
phillipb
left a comment
There was a problem hiding this comment.
Looks good. Just a naming change.
| timeUnit: schema.string(), | ||
| timeSize: schema.number(), | ||
| indexPattern: schema.string(), | ||
| expressions: schema.arrayOf( |
Contributor
There was a problem hiding this comment.
We planned to change the name to criteria.
Zacqary
added
the
release_note:skip
Contributor
Author
|
@elasticmachine merge upstream |
Contributor
Author
|
@elasticmachine merge upstream |
Contributor
Author
|
@elasticmachine merge upstream |
Contributor
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
Zacqary
added a commit
to Zacqary/kibana
that referenced
this pull request
Feb 28, 2020
elastic#58672) * Add support for multiple alert expressions * Rename expressions to criteria Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
jloleysens
added a commit
to jloleysens/kibana
that referenced
this pull request
Mar 2, 2020
…dex-server-side * 'master' of github.com:elastic/kibana: (34 commits) [Upgrade Assistant] Remove "boom" from reindex service (elastic#58715) [data] Clean up QueryStringInput unit tests (elastic#58704) [SIEM] Detection Fix typo in Adobe Hijack Persistence rule (elastic#58804) Restores [SIEM][CASE] Init Configure Case Page (elastic#58121) (elastic#58924) Skips additional failing Ingest Manager integration tests Skips failing Ingest Manager integration tests Move dev tools styles to NP (elastic#58855) change to have kibana --ssl cli option use more recent certs (elastic#57933) disable failing suite (elastic#58942) Don't start pollEsNodesVersion unless someone subscribes (elastic#56923) Do not write UUID file during optimize process (elastic#58899) [Endpoint] Task/add nav bar (elastic#58604) [Metric Alerts] Add backend support for multiple expressions per alert (elastic#58672) [Metrics Alerts] Fix alerting on a rate aggregation (elastic#58789) disable flaky suite (elastic#55953) Revert "[SIEM] apollo@3 (elastic#51926)" and "[SIEM][CASE] Init Confi… (elastic#58806) [resubmit] Prep agg types for new platform (elastic#58893) [Lens] Allow number formatting within Lens (elastic#56253) [Autocomplete] Use settings from config rather than UI settings (elastic#58784) Improve action and trigger types (elastic#58657) ... # Conflicts: # x-pack/plugins/upgrade_assistant/server/routes/reindex_indices/reindex_indices.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #58669
(Based off #57606, don't merge until rebasing)
This adds support for multiple expressions AND'ed together in a metric threshold alert.
Checklist
Delete any items that are not applicable to this PR.
[ ] Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support[ ] Documentation was added for features that require explanation or tutorials[ ] This was checked for keyboard-only and screenreader accessibility[ ] This renders correctly on smaller devices using a responsive layout. (You can test this in your browser[ ] This was checked for cross-browser compatibility, including a check against IE11For maintainers