[kbn/ui-shared-deps] load base css file#58520
Merged
spalger merged 2 commits intoelastic:masterfrom Feb 26, 2020
Merged
Conversation
spalger
added
release_note:skip
Contributor
|
Pinging @elastic/kibana-operations (Team:Operations) |
poffdeluxe
approved these changes
Feb 25, 2020
Contributor
poffdeluxe
left a comment
poffdeluxe
left a comment
There was a problem hiding this comment.
Pulled it down locally and it worked great
Contributor
Author
|
@elasticmachine merge upstream |
Contributor
💚 Build SucceededTo update your PR or re-run it, just comment with: |
spalger
pushed a commit
to spalger/kibana
that referenced
this pull request
Feb 26, 2020
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
This was referenced Feb 26, 2020
spalger
pushed a commit
that referenced
this pull request
Feb 26, 2020
Contributor
Author
|
7.x/7.7: 650a317 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When we moved the mocaco editor into the
@kbn/ui-shared-depspackage we broke many of it's core styles because this is the first package that actually has non-themed styles. Those styles are written by webpack topackages/kbn-ui-shared-deps/target/kbn-ui-shared-deps.csswhich must be loaded by the front end to get the relevant styles.Issue pointed out by @sulemanof in #58075 (comment)