Skip to content

Dashboard: load a default rather than starting new#5851

Closed
LuudJanssen wants to merge 9 commits intoelastic:masterfrom
LuudJanssen:feature/defaultDashboards
Closed

Dashboard: load a default rather than starting new#5851
LuudJanssen wants to merge 9 commits intoelastic:masterfrom
LuudJanssen:feature/defaultDashboards

Conversation

@LuudJanssen
Copy link

Closes #5820
Also did some code cleanup in the files I was working with.

@ghost
Copy link

ghost commented Jan 8, 2016

Jenkins standing by to test this. If you aren't a maintainer, you can ignore this comment. Someone with commit access, please review this and clear it for Jenkins to run; then say 'jenkins, test it'.

@spalger spalger changed the title Closes #5820 - Dashboard: load a default rather than starting new Dashboard: load a default rather than starting new Jan 12, 2016
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would prefer that we didn't have a route for /dashboard/new. I think we should simply be redirecting requests from /dashboard to /dashboard/:id if a default dashboard is defined.

I think we should instead use a query string to tell the route handler for /dashboard that we are not interested in redirecting but definitely want a blank dashboard, something like ?create=true or ?default=false.

@ghost
Copy link

ghost commented Feb 20, 2016

Jenkins standing by to test this. If you aren't a maintainer, you can ignore this comment. Someone with commit access, please review this and clear it for Jenkins to run; then say 'jenkins, test it'.

@rashidkpc
Copy link
Contributor

Haven't seen any feedback from the submitter, closing to clean up list. @LuudJanssen please feel free to open a new pull if you'd like to address the issues above. This looks like good functionality that just needs some small changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants