Dashboard: load a default rather than starting new#5851
Dashboard: load a default rather than starting new#5851LuudJanssen wants to merge 9 commits intoelastic:masterfrom LuudJanssen:feature/defaultDashboards
Conversation
|
Jenkins standing by to test this. If you aren't a maintainer, you can ignore this comment. Someone with commit access, please review this and clear it for Jenkins to run; then say 'jenkins, test it'. |
There was a problem hiding this comment.
I would prefer that we didn't have a route for /dashboard/new. I think we should simply be redirecting requests from /dashboard to /dashboard/:id if a default dashboard is defined.
I think we should instead use a query string to tell the route handler for /dashboard that we are not interested in redirecting but definitely want a blank dashboard, something like ?create=true or ?default=false.
|
Jenkins standing by to test this. If you aren't a maintainer, you can ignore this comment. Someone with commit access, please review this and clear it for Jenkins to run; then say 'jenkins, test it'. |
|
Haven't seen any feedback from the submitter, closing to clean up list. @LuudJanssen please feel free to open a new pull if you'd like to address the issues above. This looks like good functionality that just needs some small changes |
Closes #5820
Also did some code cleanup in the files I was working with.