Skip to content

Don't mutate error message #58452

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 25, 2020
Merged

Don't mutate error message #58452

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e4634c4
fix: 🐛 don't mutate error object in-place
streamich Feb 25, 2020
eb4f516
test: 💍 capture in test that thrown error is not mutated
streamich Feb 25, 2020
db3d9fc
Merge branch 'master' into dont-mutate-error
elasticmachine Feb 25, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/plugins/expressions/common/execution/execution.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -630,6 +630,7 @@ describe('Execution', () => {
},
});
expect(node2.debug?.rawError).toBeInstanceOf(Error);
expect(node2.debug?.rawError).toEqual(new Error('foo'));
});

test('sets .debug object to expected shape', async () => {
Expand Down
2 changes: 1 addition & 1 deletion src/plugins/expressions/common/execution/execution.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -230,8 +230,8 @@ export class Execution<
input = output;
} catch (rawError) {
const timeEnd: number = this.params.debug ? performance.now() : 0;
rawError.message = `[${fnName}] > ${rawError.message}`;
const error = createError(rawError) as ExpressionValueError;
error.error.message = `[${fnName}] > ${error.error.message}`;

if (this.params.debug) {
(link as ExpressionAstFunction).debug = {
Expand Down