Skip to content

Skip flaky alert details test#58120

Merged
spalger merged 3 commits intoelastic:masterfrom
mikecote:skip-flaky-57426
Feb 20, 2020
Merged

Skip flaky alert details test#58120
spalger merged 3 commits intoelastic:masterfrom
mikecote:skip-flaky-57426

Conversation

@mikecote
Copy link
Contributor

This PR re-skips a flaky test that got un-skipped a little too soon (from: #57715). I previously forgot to add a comment with the original issue which is now there.

@mikecote mikecote added Feature:Alerting v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.7.0 Team:ResponseOps Platform ResponseOps team (formerly the Cases and Alerting teams) t// labels Feb 20, 2020
@mikecote mikecote requested a review from a team as a code owner February 20, 2020 13:10
@mikecote mikecote self-assigned this Feb 20, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-alerting-services (Team:Alerting Services)

Copy link
Contributor

@spalger spalger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@YulNaumenko YulNaumenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@spalger
Copy link
Contributor

spalger commented Feb 20, 2020

I'm overriding the CI checks and merging without a green since there is basically no way for this to fail and I don't want any more people to trip up on this failure than necessary.

@spalger spalger merged commit 783663f into elastic:master Feb 20, 2020
mikecote added a commit to mikecote/kibana that referenced this pull request Feb 20, 2020
* Skip flaky test

* Skip suite

* Skip suite
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

mikecote added a commit that referenced this pull request Feb 20, 2020
* Skip flaky test

* Skip suite

* Skip suite
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Feature:Alerting release_note:skip Skip the PR/issue when compiling release notes Team:ResponseOps Platform ResponseOps team (formerly the Cases and Alerting teams) t// v7.7.0 v8.0.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants