[ML] Transform functional tests - bootstrap transform job for clone test#57992
Merged
pheyos merged 5 commits intoelastic:masterfrom Feb 20, 2020
Merged
[ML] Transform functional tests - bootstrap transform job for clone test#57992pheyos merged 5 commits intoelastic:masterfrom
pheyos merged 5 commits intoelastic:masterfrom
Conversation
pheyos
added
:ml
test_ui_functional
v8.0.0
release_note:skip
Contributor
|
Pinging @elastic/ml-ui (:ml) |
walterra
approved these changes
Feb 19, 2020
Contributor
walterra
left a comment
walterra
left a comment
There was a problem hiding this comment.
LGTM, just added a question about some after() code.
Comment on lines
+49
to
+51
| after(async () => { | ||
| // await transform.api.deleteIndices(<CLONE_DEST_INDEX>); | ||
| }); |
Contributor
There was a problem hiding this comment.
Is this here so we can follow up with some code here or can we delete it?
Member
Author
There was a problem hiding this comment.
This is a reminder to remove the clone destination index (which should be different from the original's destination index). We can as well remove it for now and re-add it when the test is actually implemented. Your call 😉
Contributor
There was a problem hiding this comment.
Fine with me to keep as is!
Member
Author
|
@elasticmachine merge upstream |
Member
Author
|
@elasticmachine merge upstream |
Contributor
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
pheyos
added a commit
to pheyos/kibana
that referenced
this pull request
Feb 20, 2020
…est (elastic#57992) This PR adds transform bootstrapping to the functional test transform.api service and demonstrates the usage in a new cloning test file, which will be completed as part of the transform cloning PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds transform bootstrapping to the functional test
transform.apiservice and demonstrates the usage in a newcloningtest file, which will be completed as part of the transform cloning PR.Relates to #57837