[Remote clusters] Fix regression with xpack.remote_clusters.ui.enabled setting#57895
Merged
alisonelizabeth merged 1 commit intoelastic:masterfrom Feb 19, 2020
Merged
Conversation
alisonelizabeth
added
v8.0.0
Team:Kibana Management
Contributor
|
Pinging @elastic/es-ui (Team:Elasticsearch UI) |
Contributor
💚 Build SucceededTo update your PR or re-run it, just comment with: |
jloleysens
approved these changes
Feb 19, 2020
Contributor
jloleysens
left a comment
jloleysens
left a comment
There was a problem hiding this comment.
Changes look good to me!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a regression caused by #57365, which inadvertently removed support for the
xpack.remote_clusters.ui.enabledsetting. This caused the following error when it was defined:How to test
xpack.remote_clusters.ui.enabledsetting in yourkibana.dev.ymlfile.falseshould disable the remote_clusters UI, but the API should still be accessible.true(default), the remote clusters UI should be enabled and behave as expected.