Fix useRequest to support query change#57723
Merged
nchaulet merged 1 commit intoelastic:masterfrom Feb 19, 2020
Merged
Conversation
nchaulet
added
the
Team:Kibana Management
Contributor
|
Pinging @elastic/es-ui (Team:Elasticsearch UI) |
nchaulet
added
the
release_note:skip
alisonelizabeth
approved these changes
Feb 19, 2020
Contributor
alisonelizabeth
left a comment
alisonelizabeth
left a comment
There was a problem hiding this comment.
@nchaulet Thanks for taking this on! Code LGTM. I tested our apps that currently consume this - watcher and index templates - and everything still worked as expected. It actually resolved an issue in watcher that also passes a query string (related code) - so thank you for that!
I approve, but left one note about updating the comment in the code. If you could address that before merging, that would be great.
nchaulet
force-pushed
the
feature-use-request-57652
branch
from
0762e19 to
a3c837a
Compare
Contributor
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
This was referenced Feb 19, 2020
mbondyra
added a commit
to mbondyra/kibana
that referenced
this pull request
Feb 20, 2020
* master: (136 commits) [Visualize] Remove legacy appState in visualize (elastic#57330) Use static time for tsvb rollup test (elastic#57701) [SIEM] Fix ResizeObserver polyfill (elastic#58046) [SIEM][Detection Engine] Fixes return codes where some were rule_id instead of id skip flaky suite (elastic#56816) skip flaky suite (elastic#58059) skip flaky suite (elastic#45348) migrates notification server routes to NP (elastic#57906) Moved all of the show/hide toggles outside of ordered lists. (elastic#57163) [APM] NP Migration - Moves plugin server files out of legacy (elastic#57532) [Maps][Telemetry] Migrate Maps telemetry to NP (elastic#55055) Embeddable add panel examples (elastic#57319) Fix useRequest to support query change (elastic#57723) Allow custom paths in plugin generator (elastic#57766) [SIEM][Case] Merge header components (elastic#57816) [ML] New Platform server shim: update job audit messages routes (elastic#57925) [kbn/optimizer] emit success event from reducer when all bundles cached (elastic#57945) [APM] Don’t include UI filters when fetching a specific transaction (elastic#57934) Upgrade yargs (elastic#57720) skip flaky suite (elastic#57762) (elastic#57997) (elastic#57998) ... # Conflicts: # src/plugins/advanced_settings/public/management_app/components/field/__snapshots__/field.test.tsx.snap # src/plugins/advanced_settings/public/management_app/components/field/field.tsx # x-pack/plugins/translations/translations/ja-JP.json # x-pack/plugins/translations/translations/zh-CN.json
nchaulet
added a commit
that referenced
this pull request
Feb 20, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Resolves #57652
My attempt to Fix useRequest hooks to reload when query change.
No visual changes
In fleet and EPM we use a lot useRequest and we will need this hook to trigger request if the query change.
Checklist
Delete any items that are not applicable to this PR.