Alerting plugin migrate to Kibana platform#57635
Merged
YulNaumenko merged 29 commits intoelastic:masterfrom Feb 18, 2020
Merged
Alerting plugin migrate to Kibana platform#57635YulNaumenko merged 29 commits intoelastic:masterfrom
YulNaumenko merged 29 commits intoelastic:masterfrom
Conversation
…rate-to-kibana-platform # Conflicts: # .github/CODEOWNERS # x-pack/legacy/plugins/alerting/common/alert.ts # x-pack/legacy/plugins/alerting/common/types.ts # x-pack/legacy/plugins/siem/server/lib/detection_engine/rules/update_prepacked_rules.ts # x-pack/legacy/plugins/siem/server/lib/detection_engine/rules/update_rules.ts # x-pack/plugins/alerting/common/types.ts # x-pack/plugins/alerting/server/alerts_client.ts # x-pack/plugins/alerting/server/task_runner/alert_task_instance.ts # x-pack/plugins/alerting/server/types.ts
…rate-to-kibana-platform # Conflicts: # x-pack/legacy/plugins/alerting/server/plugin.ts
YulNaumenko
added
Feature:Alerting
v8.0.0
release_note:skip
Contributor
|
Pinging @elastic/kibana-alerting-services (Team:Alerting Services) |
gmmorris
approved these changes
Feb 13, 2020
Contributor
gmmorris
left a comment
gmmorris
left a comment
There was a problem hiding this comment.
LGTM, thanks for sorting the git mv issue :)
mikecote
approved these changes
Feb 14, 2020
x-pack/test/alerting_api_integration/security_and_spaces/tests/alerting/create.ts
Outdated
Show resolved
Hide resolved
pmuellr
approved these changes
Feb 14, 2020
Contributor
pmuellr
left a comment
pmuellr
left a comment
There was a problem hiding this comment.
LGTM, except for (I think) a missing if (!this.isInitialized) in alerts_client_factory.ts. Made some other nit-level comments.
Learned a bunch of new NP and TS tricks with this as well!
| private readonly spaceIdToNamespace: SpaceIdToNamespaceFunction; | ||
| private readonly encryptedSavedObjectsPlugin: EncryptedSavedObjectsPluginStart; | ||
| private isInitialized = false; | ||
| private logger!: Logger; |
Contributor
There was a problem hiding this comment.
Today I learned about using ! on properties like logger!! Wonder what @gmmorris thinks of that!? I'm happy with it for now, we seem to have multiple patterns to create plugin internal and exposed objects during setup/start, long-term perhaps we can settle on one.
| ): AlertsClient { | ||
| const { securityPluginSetup } = this; | ||
| const spaceId = this.getSpaceId(legacyRequest); | ||
| const spaceId = this.getSpaceId(request); |
Contributor
There was a problem hiding this comment.
I think we want a if (!this.isInitialized) throw new Error('not initialized') in here.
| }; | ||
| } | ||
|
|
||
| private createRouteHandlerContext = (): IContextProvider< |
Contributor
There was a problem hiding this comment.
cool - hadn't seen a real use of this yet. I wonder if we could move more stuff in here over time, like the license check, but that's for another PR :-)
x-pack/plugins/alerting/server/routes/_mock_handler_arguments.ts
Outdated
Show resolved
Hide resolved
x-pack/test/alerting_api_integration/security_and_spaces/tests/alerting/create.ts
Outdated
Show resolved
Hide resolved
…igrate-to-kibana-platform # Conflicts: # x-pack/legacy/plugins/siem/server/lib/detection_engine/routes/__mocks__/_mock_server.ts # x-pack/legacy/plugins/siem/server/lib/detection_engine/rules/get_existing_prepackaged_rules.test.ts # x-pack/legacy/plugins/siem/server/lib/detection_engine/rules/get_export_all.test.ts # x-pack/legacy/plugins/siem/server/lib/detection_engine/rules/get_export_by_object_ids.test.ts # x-pack/legacy/plugins/siem/server/lib/detection_engine/rules/read_rules.test.ts # x-pack/legacy/plugins/siem/server/lib/detection_engine/rules/types.ts # x-pack/legacy/plugins/siem/server/lib/detection_engine/signals/types.ts # x-pack/legacy/plugins/siem/server/lib/detection_engine/tags/read_tags.test.ts
…igrate-to-kibana-platform # Please enter a commit message to explain why this merge is necessary, # especially if it merges an updated upstream into a topic branch. # # Lines starting with '#' will be ignored, and an empty message aborts # the commit.
…igrate-to-kibana-platform # Please enter a commit message to explain why this merge is necessary, # especially if it merges an updated upstream into a topic branch. # # Lines starting with '#' will be ignored, and an empty message aborts # the commit.
Contributor
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Migrates the Alerting plugin from Legacy on to the Kibana Platform.
Closes #51652
Checklist
Delete any items that are not applicable to this PR.