[APM] NP Migration - Saved Objects Client#57438
Closed
ogupte wants to merge 2 commits intoelastic:masterfrom
Closed
[APM] NP Migration - Saved Objects Client#57438ogupte wants to merge 2 commits intoelastic:masterfrom
ogupte wants to merge 2 commits intoelastic:masterfrom
Conversation
and context scoped clients exposed in the new platform core setup
jasonrhodes
reviewed
Feb 12, 2020
| const apmIndices = await framework.plugins.apm.getApmIndices( | ||
| requestContext.core.savedObjects.client | ||
| ); | ||
| const apmIndices = await framework.plugins.apm.getApmIndices(); |
jasonrhodes
approved these changes
Feb 12, 2020
Member
jasonrhodes
left a comment
There was a problem hiding this comment.
infra changes LGTM, thanks!
Contributor
Author
|
@elasticmachine merge upstream |
Contributor
💔 Build FailedTest FailuresKibana Pipeline / kibana-xpack-agent / Chrome X-Pack UI Functional Tests.x-pack/test/functional/apps/advanced_settings/feature_controls/advanced_settings_security·ts.Advanced Settings security feature controls no advanced_settings privileges does not allow navigation to advanced settings; redirects to management homeStandard OutStack TraceKibana Pipeline / kibana-xpack-agent / Chrome X-Pack UI Functional Tests.x-pack/test/functional/apps/rollup_job/tsvb·js.rollup app tsvb integration create rollup tsvbStandard OutStack TraceKibana Pipeline / kibana-xpack-agent / X-Pack API Integration Tests.x-pack/test/api_integration/apis/apm/feature_controls·ts.apis APM apm feature controls spaces user_1 can access APIs in space_1Standard OutStack Traceand 2 more failures, only showing the first 3. History
To update your PR or re-run it, just comment with: |
Contributor
Author
|
Closing this since it's already part of another PR: #57532 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #56832
Migrates uses of the saved objects client to the internal and context scoped clients exposed in the new platform core setup.