[ML] Anomaly Detection: Fix jobs list default refresh.#57086
Merged
jgowdyelastic merged 6 commits intoelastic:masterfrom Feb 11, 2020
Merged
[ML] Anomaly Detection: Fix jobs list default refresh.#57086jgowdyelastic merged 6 commits intoelastic:masterfrom
jgowdyelastic merged 6 commits intoelastic:masterfrom
Conversation
walterra
added
bug
walterra
requested review from
alvarezmelissa87,
darnautov,
jgowdyelastic and
peteharverson
Contributor
|
Pinging @elastic/ml-ui (:ml) |
Contributor
💔 Build FailedTest FailuresKibana Pipeline / kibana-xpack-agent / Chrome X-Pack UI Functional Tests.x-pack/test/functional/apps/machine_learning/anomaly_detection/single_metric_job·ts.machine learning anomaly detection single metric job creation displays the created job in the job listStandard OutStack TraceKibana Pipeline / kibana-xpack-agent / Chrome X-Pack UI Functional Tests.x-pack/test/functional/apps/machine_learning/anomaly_detection/single_metric_job·ts.machine learning anomaly detection single metric job creation displays the created job in the job listStandard OutStack TraceTo update your PR or re-run it, just comment with: |
| } else { | ||
| this.setRefreshInterval(value); | ||
| componentDidUpdate(prevProps) { | ||
| if (prevProps.lastRefresh !== this.props.lastRefresh && this.props.blockRefresh === false) { |
Member
There was a problem hiding this comment.
as blockRefresh is optional, should this check be for !== true?
do we want to treat a non-existing blockRefresh as being a false condition? if that makes sense.
Contributor
Author
Contributor
|
If I open the page with a refresh interval set in the URL, such as |
…eshInterval when loading jobs list.
Contributor
Author
|
@peteharverson Hopefully fixed with 4212c9e. We were retaining the |
alvarezmelissa87
approved these changes
Feb 10, 2020
Contributor
alvarezmelissa87
left a comment
alvarezmelissa87
left a comment
There was a problem hiding this comment.
Tested and LGTM ⚡️
Contributor
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
peteharverson
approved these changes
Feb 11, 2020
Contributor
peteharverson
left a comment
peteharverson
left a comment
There was a problem hiding this comment.
Tested latest edits and LGTM.
jgowdyelastic
pushed a commit
to jgowdyelastic/kibana
that referenced
this pull request
Feb 11, 2020
* [ML] Fix anomaly detection jobs list default refresh. * [ML] Fix initial load of jobs list. * [ML] Fix blockRefresh check. * [ML] Fix blockRefresh check. * [ML] Fix passing globalState between main tabs and retain custom refreshInterval when loading jobs list.
jgowdyelastic
added a commit
that referenced
this pull request
Feb 11, 2020
* [ML] Fix anomaly detection jobs list default refresh. * [ML] Fix initial load of jobs list. * [ML] Fix blockRefresh check. * [ML] Fix blockRefresh check. * [ML] Fix passing globalState between main tabs and retain custom refreshInterval when loading jobs list. Co-authored-by: Walter Rafelsberger <walter@rafelsberger.at>
jgowdyelastic
pushed a commit
to jgowdyelastic/kibana
that referenced
this pull request
Feb 11, 2020
* [ML] Fix anomaly detection jobs list default refresh. * [ML] Fix initial load of jobs list. * [ML] Fix blockRefresh check. * [ML] Fix blockRefresh check. * [ML] Fix passing globalState between main tabs and retain custom refreshInterval when loading jobs list.
jgowdyelastic
added a commit
that referenced
this pull request
Feb 11, 2020
* [ML] Fix anomaly detection jobs list default refresh. * [ML] Fix initial load of jobs list. * [ML] Fix blockRefresh check. * [ML] Fix blockRefresh check. * [ML] Fix passing globalState between main tabs and retain custom refreshInterval when loading jobs list. Co-authored-by: Walter Rafelsberger <walter@rafelsberger.at> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #56499.
Regression introduced by #52986.
30srefresh for the anomaly detection jobs list if no other refresh is already set.lastRefreshpattern we use on other pages: The route level component subscribes to date picker updates and passes on thelastRefreshtimestamp.blockRefreshis now also managed on the router level and passed on as a prop.Checklist
Delete any items that are not applicable to this PR.
For maintainers