Skip to content

fix for chart_types test #57056

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rashmivkulkarni merged 2 commits into from
Feb 7, 2020
Merged

fix for chart_types test #57056

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b7c9a10
fix for chart_types test
rashmivkulkarni Feb 6, 2020
eb3db18
Merge branch 'master' into chart_type_test
elasticmachine Feb 6, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 10 additions & 3 deletions test/functional/apps/visualize/_chart_types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@
* under the License.
*/

import _ from 'lodash';
import expect from '@kbn/expect';
import { FtrProviderContext } from '../../ftr_provider_context';

Expand All @@ -34,7 +35,7 @@ export default function({ getService, getPageObjects }: FtrProviderContext) {
});

it('should show the correct chart types', async function() {
const expectedChartTypes = [
let expectedChartTypes = [
'Area',
'Controls',
'Coordinate Map',
Expand All @@ -55,13 +56,19 @@ export default function({ getService, getPageObjects }: FtrProviderContext) {
'Vertical Bar',
];
if (!isOss) {
expectedChartTypes.push('Maps');
expectedChartTypes.push('Maps', 'Lens');
expectedChartTypes = _.remove(expectedChartTypes, function(n) {
return n !== 'Coordinate Map';
});
expectedChartTypes = _.remove(expectedChartTypes, function(n) {
return n !== 'Region Map';
});
expectedChartTypes.sort();
}
log.debug('oss= ' + isOss);

// find all the chart types and make sure there all there
const chartTypes = await PageObjects.visualize.getChartTypes();
const chartTypes = (await PageObjects.visualize.getChartTypes()).sort();
log.debug('returned chart types = ' + chartTypes);
log.debug('expected chart types = ' + expectedChartTypes);
expect(chartTypes).to.eql(expectedChartTypes);
Expand Down