[Metrics UI] Setup commonly used time ranges in timepicker #56701
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simianhacker
added
Feature:Metrics UI
Contributor
|
Pinging @elastic/logs-metrics-ui (Team:logs-metrics-ui) |
afgomez
reviewed
Feb 6, 2020
Contributor
There was a problem hiding this comment.
The code is good. I would move the duplicated code to a shared place, especially because this is useful for me as well for the logs UI.
Edit: if you cannot think of a good place to place the shared code we can merge this now and tackle that later, when I add this to my PR.
x-pack/legacy/plugins/infra/public/pages/metrics/components/time_controls.tsx
Outdated
Show resolved
Hide resolved
x-pack/legacy/plugins/infra/public/pages/metrics/components/time_controls.tsx
Outdated
Show resolved
Hide resolved
…ges; reduce duplicate code for mapping quick ranges
Member
Author
|
@afgomez I changed the function definition for |
Member
Author
|
@elasticmachine merge upstream |
Member
Author
|
@elasticmachine merge upstream |
Contributor
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
simianhacker
added a commit
to simianhacker/kibana
that referenced
this pull request
Feb 10, 2020
…6701) * [Metrics UI] Setup commonly used time ranges in timepicker * Fixing tests by mocking out useKibanaUISetting * add definition override to useKibanaUISetting for timepicker:quickRanges; reduce duplicate code for mapping quick ranges * Fixing types Co-authored-by: Elastic Machine <[email protected]>
simianhacker
added a commit
that referenced
this pull request
Feb 11, 2020
…57253) * [Metrics UI] Setup commonly used time ranges in timepicker * Fixing tests by mocking out useKibanaUISetting * add definition override to useKibanaUISetting for timepicker:quickRanges; reduce duplicate code for mapping quick ranges * Fixing types Co-authored-by: Elastic Machine <[email protected]> Co-authored-by: Elastic Machine <[email protected]>
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Feb 11, 2020
* master: (34 commits) [Index management] Server-side NP ready (elastic#56829) Webhook action - make user and password secrets optional (elastic#56823) [DOCS] Removes reference to IRC (elastic#57245) [Monitoring] NP migration: Local angular module (elastic#51823) [SIEM] Adds ECS link to help menu (elastic#57104) Ensure http interceptors are shares across lifecycle methods (elastic#57150) [Remote clusters] Migrate server code out of legacy (elastic#56781) fixes render bug in alert list (elastic#57152) siem 7.6 updates (elastic#57169) Make the update alert API key API work when AAD is out of sync (elastic#56640) fix(NA): MaxListenersExceededWarning on getLoggerStream (elastic#57133) [Metrics UI] Setup commonly used time ranges in timepicker (elastic#56701) [Maps] set filter.meta.key to geoFieldName so query passes filterMatchesIndex when ignoreFilterIfFieldNotInIndex is true (elastic#56692) Create plugin mock for event log plugin (elastic#57048) fix ts error on master (elastic#57236) Don't create API key for disabled alerts when calling create API (elastic#57041) Fix enable and disable API to still work when AAD is out of sync (elastic#56634) [DOCS] Canvas embed objects (elastic#57156) Delete autocomplete namespace (elastic#57187) Security - Inject logout url (elastic#57201) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes #50191 by using the
timepicker:quickRangesto populate thecommonlyUsedRangesargument on theEuiSuperDatePicker.Before
Metrics Explorer
Metric Detail Page
After
Metrics Explorer
Metric Detail Page